all lists on lists.proxmox.com
 help / color / mirror / Atom feed
From: Dominik Csapak <d.csapak@proxmox.com>
To: pdm-devel@lists.proxmox.com
Subject: [PATCH yew-widget-toolkit] widget: map: fix info positioning on firefox
Date: Tue, 26 May 2026 15:33:14 +0200	[thread overview]
Message-ID: <20260526133321.3346385-1-d.csapak@proxmox.com> (raw)

On at least some firefox versions (tested with 140 ESR), drawing an SVG
circle with radius 0 does not position it correctly (it will in the SVG
origin instead of the specified coordinates). This lead to the info
popup on the map to be always relative to the top left of the whole map,
instead of above the selected point.

To fix this, make the circle have a radius of 1 and make it transparent.

Signed-off-by: Dominik Csapak <d.csapak@proxmox.com>
---
 src/widget/charts/map/mod.rs | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/src/widget/charts/map/mod.rs b/src/widget/charts/map/mod.rs
index 225a851..d6d142a 100644
--- a/src/widget/charts/map/mod.rs
+++ b/src/widget/charts/map/mod.rs
@@ -446,7 +446,8 @@ impl<T: MapPointData + 'static> yew::Component for MapComp<T> {
                     Circle::new()
                         .cx(center.x)
                         .cy(center.y)
-                        .r(0)
+                        .r(1)
+                        .fill("transparent")
                         .into_html_with_ref(self.info_anchor_ref.clone()),
                 );
                 info = Some(self.create_info(&args));
-- 
2.47.3





             reply	other threads:[~2026-05-26 13:33 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-05-26 13:33 Dominik Csapak [this message]
2026-05-26 23:11 ` applied: [PATCH yew-widget-toolkit] widget: map: fix info positioning on firefox Thomas Lamprecht

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20260526133321.3346385-1-d.csapak@proxmox.com \
    --to=d.csapak@proxmox.com \
    --cc=pdm-devel@lists.proxmox.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.
Service provided by Proxmox Server Solutions GmbH | Privacy | Legal