* [PATCH pve-manager] ui: add online help link for prefix lists and route maps
@ 2026-05-19 12:29 Christian Ebner
2026-05-19 15:16 ` Shannon Sterz
2026-05-19 19:17 ` applied: " Thomas Lamprecht
0 siblings, 2 replies; 3+ messages in thread
From: Christian Ebner @ 2026-05-19 12:29 UTC (permalink / raw)
To: pve-devel
These have several config options which are worth to be easily looked
up by directly providing the link to the docs.
Signed-off-by: Christian Ebner <c.ebner@proxmox.com>
---
www/manager6/sdn/PrefixListPanel.js | 2 ++
www/manager6/sdn/RouteMapPanel.js | 2 ++
2 files changed, 4 insertions(+)
diff --git a/www/manager6/sdn/PrefixListPanel.js b/www/manager6/sdn/PrefixListPanel.js
index d8ce3db8..d678356c 100644
--- a/www/manager6/sdn/PrefixListPanel.js
+++ b/www/manager6/sdn/PrefixListPanel.js
@@ -45,6 +45,8 @@ Ext.define('PVE.sdn.EditPrefixListEntryWindow', {
extend: 'Proxmox.window.Edit',
mixins: ['Proxmox.Mixin.CBind'],
+ onlineHelp: 'pvesdn_config_prefix_lists',
+
// TRANSLATORS: Refers to an FRR prefix list, some languages may prefer to
// keep "prefix list" as-is:
// https://docs.frrouting.org/en/latest/filter.html#ip-prefix-list
diff --git a/www/manager6/sdn/RouteMapPanel.js b/www/manager6/sdn/RouteMapPanel.js
index 46f243fb..25630d8c 100644
--- a/www/manager6/sdn/RouteMapPanel.js
+++ b/www/manager6/sdn/RouteMapPanel.js
@@ -709,6 +709,8 @@ Ext.define('PVE.sdn.EditRouteMapEntryWindow', {
// https://docs.frrouting.org/en/latest/routemap.html
subject: gettext('Route Map Entry'),
+ onlineHelp: 'pvesdn_config_route_maps',
+
initComponent: function () {
let me = this;
me.method = me.isCreate ? 'POST' : 'PUT';
--
2.47.3
^ permalink raw reply related [flat|nested] 3+ messages in thread* Re: [PATCH pve-manager] ui: add online help link for prefix lists and route maps
2026-05-19 12:29 [PATCH pve-manager] ui: add online help link for prefix lists and route maps Christian Ebner
@ 2026-05-19 15:16 ` Shannon Sterz
2026-05-19 19:17 ` applied: " Thomas Lamprecht
1 sibling, 0 replies; 3+ messages in thread
From: Shannon Sterz @ 2026-05-19 15:16 UTC (permalink / raw)
To: Christian Ebner, pve-devel
On Tue May 19, 2026 at 2:29 PM CEST, Christian Ebner wrote:
> These have several config options which are worth to be easily looked
> up by directly providing the link to the docs.
>
> Signed-off-by: Christian Ebner <c.ebner@proxmox.com>
> ---
> www/manager6/sdn/PrefixListPanel.js | 2 ++
> www/manager6/sdn/RouteMapPanel.js | 2 ++
> 2 files changed, 4 insertions(+)
>
> diff --git a/www/manager6/sdn/PrefixListPanel.js b/www/manager6/sdn/PrefixListPanel.js
> index d8ce3db8..d678356c 100644
> --- a/www/manager6/sdn/PrefixListPanel.js
> +++ b/www/manager6/sdn/PrefixListPanel.js
> @@ -45,6 +45,8 @@ Ext.define('PVE.sdn.EditPrefixListEntryWindow', {
> extend: 'Proxmox.window.Edit',
> mixins: ['Proxmox.Mixin.CBind'],
>
> + onlineHelp: 'pvesdn_config_prefix_lists',
> +
> // TRANSLATORS: Refers to an FRR prefix list, some languages may prefer to
> // keep "prefix list" as-is:
> // https://docs.frrouting.org/en/latest/filter.html#ip-prefix-list
> diff --git a/www/manager6/sdn/RouteMapPanel.js b/www/manager6/sdn/RouteMapPanel.js
> index 46f243fb..25630d8c 100644
> --- a/www/manager6/sdn/RouteMapPanel.js
> +++ b/www/manager6/sdn/RouteMapPanel.js
> @@ -709,6 +709,8 @@ Ext.define('PVE.sdn.EditRouteMapEntryWindow', {
> // https://docs.frrouting.org/en/latest/routemap.html
> subject: gettext('Route Map Entry'),
>
> + onlineHelp: 'pvesdn_config_route_maps',
> +
> initComponent: function () {
> let me = this;
> me.method = me.isCreate ? 'POST' : 'PUT';
ah sorry somehow missed that and send a similar patch now [1]. however,
yours add help buttons to the edit/add dialogs, whereas mine affects the
top right "Help" button in the panels. imo it could still make sense to
apply both here.
not applying mine would mean that those "Help" buttons would essentially
become a second "Documentation" button.
[1]: https://lore.proxmox.com/pve-devel/20260519150415.334856-1-s.sterz@proxmox.com/T/#m59a50d54e8b5df41a3dd9ea0ecbe73ba9b9dc41a
^ permalink raw reply [flat|nested] 3+ messages in thread* applied: [PATCH pve-manager] ui: add online help link for prefix lists and route maps
2026-05-19 12:29 [PATCH pve-manager] ui: add online help link for prefix lists and route maps Christian Ebner
2026-05-19 15:16 ` Shannon Sterz
@ 2026-05-19 19:17 ` Thomas Lamprecht
1 sibling, 0 replies; 3+ messages in thread
From: Thomas Lamprecht @ 2026-05-19 19:17 UTC (permalink / raw)
To: pve-devel, Christian Ebner
On Tue, 19 May 2026 14:29:15 +0200, Christian Ebner wrote:
> These have several config options which are worth to be easily looked
> up by directly providing the link to the docs.
Applied, thanks!
[1/1] ui: add online help link for prefix lists and route maps
commit: 16cfc19a02aaad864ce4fbe673ac9816509dddcb
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2026-05-19 19:34 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2026-05-19 12:29 [PATCH pve-manager] ui: add online help link for prefix lists and route maps Christian Ebner
2026-05-19 15:16 ` Shannon Sterz
2026-05-19 19:17 ` applied: " Thomas Lamprecht
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.