all lists on lists.proxmox.com
 help / color / mirror / Atom feed
From: "Shannon Sterz" <s.sterz@proxmox.com>
To: "Christian Ebner" <c.ebner@proxmox.com>, <pve-devel@lists.proxmox.com>
Subject: Re: [PATCH pve-manager] ui: add online help link for prefix lists and route maps
Date: Tue, 19 May 2026 17:16:20 +0200	[thread overview]
Message-ID: <DIMR3P8T8XGJ.1DO8CATOJLQ9H@proxmox.com> (raw)
In-Reply-To: <20260519122915.308863-1-c.ebner@proxmox.com>

On Tue May 19, 2026 at 2:29 PM CEST, Christian Ebner wrote:
> These have several config options which are worth to be easily looked
> up by directly providing the link to the docs.
>
> Signed-off-by: Christian Ebner <c.ebner@proxmox.com>
> ---
>  www/manager6/sdn/PrefixListPanel.js | 2 ++
>  www/manager6/sdn/RouteMapPanel.js   | 2 ++
>  2 files changed, 4 insertions(+)
>
> diff --git a/www/manager6/sdn/PrefixListPanel.js b/www/manager6/sdn/PrefixListPanel.js
> index d8ce3db8..d678356c 100644
> --- a/www/manager6/sdn/PrefixListPanel.js
> +++ b/www/manager6/sdn/PrefixListPanel.js
> @@ -45,6 +45,8 @@ Ext.define('PVE.sdn.EditPrefixListEntryWindow', {
>      extend: 'Proxmox.window.Edit',
>      mixins: ['Proxmox.Mixin.CBind'],
>
> +    onlineHelp: 'pvesdn_config_prefix_lists',
> +
>      // TRANSLATORS: Refers to an FRR prefix list, some languages may prefer to
>      // keep "prefix list" as-is:
>      // https://docs.frrouting.org/en/latest/filter.html#ip-prefix-list
> diff --git a/www/manager6/sdn/RouteMapPanel.js b/www/manager6/sdn/RouteMapPanel.js
> index 46f243fb..25630d8c 100644
> --- a/www/manager6/sdn/RouteMapPanel.js
> +++ b/www/manager6/sdn/RouteMapPanel.js
> @@ -709,6 +709,8 @@ Ext.define('PVE.sdn.EditRouteMapEntryWindow', {
>      // https://docs.frrouting.org/en/latest/routemap.html
>      subject: gettext('Route Map Entry'),
>
> +    onlineHelp: 'pvesdn_config_route_maps',
> +
>      initComponent: function () {
>          let me = this;
>          me.method = me.isCreate ? 'POST' : 'PUT';

ah sorry somehow missed that and send a similar patch now [1]. however,
yours add help buttons to the edit/add dialogs, whereas mine affects the
top right "Help" button in the panels. imo it could still make sense to
apply both here.

not applying mine would mean that those "Help" buttons would essentially
become a second "Documentation" button.

[1]: https://lore.proxmox.com/pve-devel/20260519150415.334856-1-s.sterz@proxmox.com/T/#m59a50d54e8b5df41a3dd9ea0ecbe73ba9b9dc41a




  reply	other threads:[~2026-05-19 15:17 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-05-19 12:29 [PATCH pve-manager] ui: add online help link for prefix lists and route maps Christian Ebner
2026-05-19 15:16 ` Shannon Sterz [this message]
2026-05-19 19:17 ` applied: " Thomas Lamprecht

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=DIMR3P8T8XGJ.1DO8CATOJLQ9H@proxmox.com \
    --to=s.sterz@proxmox.com \
    --cc=c.ebner@proxmox.com \
    --cc=pve-devel@lists.proxmox.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.
Service provided by Proxmox Server Solutions GmbH | Privacy | Legal