* [PATCH manager] ui: run make tidy
@ 2026-05-15 9:23 Shannon Sterz
2026-05-15 9:33 ` applied: " Thomas Lamprecht
0 siblings, 1 reply; 2+ messages in thread
From: Shannon Sterz @ 2026-05-15 9:23 UTC (permalink / raw)
To: pve-devel
the recent changes for sdn and fabrics were missing proper formatting,
run make tidy to fix that, no functional changes.
Signed-off-by: Shannon Sterz <s.sterz@proxmox.com>
---
www/manager6/sdn/controllers/EvpnEdit.js | 6 ++-
.../sdn/fabrics/RedistributionGrid.js | 49 ++++++++++---------
www/manager6/sdn/fabrics/ospf/FabricEdit.js | 2 +-
.../sdn/fabrics/ospf/InterfacePanel.js | 8 +--
4 files changed, 36 insertions(+), 29 deletions(-)
diff --git a/www/manager6/sdn/controllers/EvpnEdit.js b/www/manager6/sdn/controllers/EvpnEdit.js
index 8d39e5c36..eb3c119ca 100644
--- a/www/manager6/sdn/controllers/EvpnEdit.js
+++ b/www/manager6/sdn/controllers/EvpnEdit.js
@@ -101,7 +101,11 @@ Ext.define('PVE.sdn.controllers.EvpnInputPanel', {
name: 'bgp-mode',
value: '',
emptyText: 'Automatic',
- comboItems: [['auto', gettext('Automatic')], ['external', gettext('eBGP')], ['internal', gettext('iBGP')]],
+ comboItems: [
+ ['auto', gettext('Automatic')],
+ ['external', gettext('eBGP')],
+ ['internal', gettext('iBGP')],
+ ],
fieldLabel: gettext('BGP Mode'),
allowBlank: true,
deleteEmpty: !me.isCreate,
diff --git a/www/manager6/sdn/fabrics/RedistributionGrid.js b/www/manager6/sdn/fabrics/RedistributionGrid.js
index 8d1056fdb..846ecef0c 100644
--- a/www/manager6/sdn/fabrics/RedistributionGrid.js
+++ b/www/manager6/sdn/fabrics/RedistributionGrid.js
@@ -17,7 +17,7 @@ Ext.define('PVE.sdn.Fabric.RedistributionGrid', {
model: 'PVE.sdn.Fabric.Redistribution',
listeners: {
update: 'handleUpdate',
- }
+ },
},
tbar: [
@@ -25,7 +25,7 @@ Ext.define('PVE.sdn.Fabric.RedistributionGrid', {
{
text: gettext('Add'),
handler: 'addRedistribution',
- }
+ },
],
border: false,
@@ -35,7 +35,7 @@ Ext.define('PVE.sdn.Fabric.RedistributionGrid', {
controller: {
xclass: 'Ext.app.ViewController',
- addRedistribution: function() {
+ addRedistribution: function () {
let me = this;
let source = me.getView().getSources()[0][0];
@@ -65,7 +65,7 @@ Ext.define('PVE.sdn.Fabric.RedistributionGrid', {
me.handleUpdate();
},
- handleUpdate: function() {
+ handleUpdate: function () {
let me = this;
me.getView().checkChange();
},
@@ -77,16 +77,16 @@ Ext.define('PVE.sdn.Fabric.RedistributionGrid', {
},
},
- initComponent: function() {
+ initComponent: function () {
let me = this;
if (me.getSources().length === 0) {
- throw "must define at least one redistribution source!";
+ throw 'must define at least one redistribution source!';
}
me.columns = [
{
- text: gettext("Source"),
+ text: gettext('Source'),
xtype: 'widgetcolumn',
dataIndex: 'source',
flex: 1,
@@ -97,7 +97,7 @@ Ext.define('PVE.sdn.Fabric.RedistributionGrid', {
},
},
{
- text: gettext("Route Map"),
+ text: gettext('Route Map'),
xtype: 'widgetcolumn',
dataIndex: 'route-map',
flex: 1,
@@ -108,7 +108,7 @@ Ext.define('PVE.sdn.Fabric.RedistributionGrid', {
},
...me.getAdditionalColumns(),
{
- text: gettext("Action"),
+ text: gettext('Action'),
xtype: 'actioncolumn',
width: 100,
items: [
@@ -124,28 +124,31 @@ Ext.define('PVE.sdn.Fabric.RedistributionGrid', {
me.callParent();
},
- isEqual: function(value1, value2) {
+ isEqual: function (value1, value2) {
return JSON.stringify(value1) === JSON.stringify(value2);
},
- getValue: function() {
+ getValue: function () {
let me = this;
- return me.getStore().getData().items.map((record) => {
- let data = {};
+ return me
+ .getStore()
+ .getData()
+ .items.map((record) => {
+ let data = {};
- for (const [key, value] of Object.entries(record.data)) {
- if (value === '' || value === undefined || value === null || key === 'id') {
- continue;
+ for (const [key, value] of Object.entries(record.data)) {
+ if (value === '' || value === undefined || value === null || key === 'id') {
+ continue;
+ }
+ data[key] = value;
}
- data[key] = value;
- }
- return PVE.Parser.printPropertyString(data, undefined);
- });
+ return PVE.Parser.printPropertyString(data, undefined);
+ });
},
- setValue: function(value) {
+ setValue: function (value) {
let me = this;
me.getStore().setData((value ?? []).map((item) => PVE.Parser.parsePropertyString(item)));
@@ -169,7 +172,7 @@ Ext.define('PVE.sdn.Fabric.RedistributionGrid', {
};
},
- getErrors: function(value) {
+ getErrors: function (value) {
let me = this;
let errors = [];
@@ -185,5 +188,5 @@ Ext.define('PVE.sdn.Fabric.RedistributionGrid', {
}
return errors;
- }
+ },
});
diff --git a/www/manager6/sdn/fabrics/ospf/FabricEdit.js b/www/manager6/sdn/fabrics/ospf/FabricEdit.js
index 2f057b8e8..315c99193 100644
--- a/www/manager6/sdn/fabrics/ospf/FabricEdit.js
+++ b/www/manager6/sdn/fabrics/ospf/FabricEdit.js
@@ -46,6 +46,6 @@ Ext.define('PVE.sdn.Fabric.Ospf.Fabric.Edit', {
],
},
],
- }
+ },
],
});
diff --git a/www/manager6/sdn/fabrics/ospf/InterfacePanel.js b/www/manager6/sdn/fabrics/ospf/InterfacePanel.js
index 370137cba..3a47bd524 100644
--- a/www/manager6/sdn/fabrics/ospf/InterfacePanel.js
+++ b/www/manager6/sdn/fabrics/ospf/InterfacePanel.js
@@ -23,10 +23,10 @@ Ext.define('PVE.sdn.Fabric.Ospf.NetworkTypeSelector', {
store: {
fields: ['name'],
data: [
- {name: 'broadcast'},
- {name: 'non-broadcast'},
- {name: 'point-to-multipoint'},
- {name: 'point-to-point'},
+ { name: 'broadcast' },
+ { name: 'non-broadcast' },
+ { name: 'point-to-multipoint' },
+ { name: 'point-to-point' },
],
},
});
--
2.47.3
^ permalink raw reply related [flat|nested] 2+ messages in thread
* applied: [PATCH manager] ui: run make tidy
2026-05-15 9:23 [PATCH manager] ui: run make tidy Shannon Sterz
@ 2026-05-15 9:33 ` Thomas Lamprecht
0 siblings, 0 replies; 2+ messages in thread
From: Thomas Lamprecht @ 2026-05-15 9:33 UTC (permalink / raw)
To: pve-devel, Shannon Sterz
On Fri, 15 May 2026 11:23:31 +0200, Shannon Sterz wrote:
> the recent changes for sdn and fabrics were missing proper formatting,
> run make tidy to fix that, no functional changes.
Applied, thanks!
[1/1] ui: run make tidy
commit: 0a366ac78337f972f85af86f4b4b6c5f8388554e
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2026-05-15 9:33 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2026-05-15 9:23 [PATCH manager] ui: run make tidy Shannon Sterz
2026-05-15 9:33 ` applied: " Thomas Lamprecht
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.