From: Shannon Sterz <s.sterz@proxmox.com>
To: pve-devel@lists.proxmox.com
Subject: [PATCH manager] ui: run make tidy
Date: Fri, 15 May 2026 11:23:31 +0200 [thread overview]
Message-ID: <20260515092331.86703-1-s.sterz@proxmox.com> (raw)
the recent changes for sdn and fabrics were missing proper formatting,
run make tidy to fix that, no functional changes.
Signed-off-by: Shannon Sterz <s.sterz@proxmox.com>
---
www/manager6/sdn/controllers/EvpnEdit.js | 6 ++-
.../sdn/fabrics/RedistributionGrid.js | 49 ++++++++++---------
www/manager6/sdn/fabrics/ospf/FabricEdit.js | 2 +-
.../sdn/fabrics/ospf/InterfacePanel.js | 8 +--
4 files changed, 36 insertions(+), 29 deletions(-)
diff --git a/www/manager6/sdn/controllers/EvpnEdit.js b/www/manager6/sdn/controllers/EvpnEdit.js
index 8d39e5c36..eb3c119ca 100644
--- a/www/manager6/sdn/controllers/EvpnEdit.js
+++ b/www/manager6/sdn/controllers/EvpnEdit.js
@@ -101,7 +101,11 @@ Ext.define('PVE.sdn.controllers.EvpnInputPanel', {
name: 'bgp-mode',
value: '',
emptyText: 'Automatic',
- comboItems: [['auto', gettext('Automatic')], ['external', gettext('eBGP')], ['internal', gettext('iBGP')]],
+ comboItems: [
+ ['auto', gettext('Automatic')],
+ ['external', gettext('eBGP')],
+ ['internal', gettext('iBGP')],
+ ],
fieldLabel: gettext('BGP Mode'),
allowBlank: true,
deleteEmpty: !me.isCreate,
diff --git a/www/manager6/sdn/fabrics/RedistributionGrid.js b/www/manager6/sdn/fabrics/RedistributionGrid.js
index 8d1056fdb..846ecef0c 100644
--- a/www/manager6/sdn/fabrics/RedistributionGrid.js
+++ b/www/manager6/sdn/fabrics/RedistributionGrid.js
@@ -17,7 +17,7 @@ Ext.define('PVE.sdn.Fabric.RedistributionGrid', {
model: 'PVE.sdn.Fabric.Redistribution',
listeners: {
update: 'handleUpdate',
- }
+ },
},
tbar: [
@@ -25,7 +25,7 @@ Ext.define('PVE.sdn.Fabric.RedistributionGrid', {
{
text: gettext('Add'),
handler: 'addRedistribution',
- }
+ },
],
border: false,
@@ -35,7 +35,7 @@ Ext.define('PVE.sdn.Fabric.RedistributionGrid', {
controller: {
xclass: 'Ext.app.ViewController',
- addRedistribution: function() {
+ addRedistribution: function () {
let me = this;
let source = me.getView().getSources()[0][0];
@@ -65,7 +65,7 @@ Ext.define('PVE.sdn.Fabric.RedistributionGrid', {
me.handleUpdate();
},
- handleUpdate: function() {
+ handleUpdate: function () {
let me = this;
me.getView().checkChange();
},
@@ -77,16 +77,16 @@ Ext.define('PVE.sdn.Fabric.RedistributionGrid', {
},
},
- initComponent: function() {
+ initComponent: function () {
let me = this;
if (me.getSources().length === 0) {
- throw "must define at least one redistribution source!";
+ throw 'must define at least one redistribution source!';
}
me.columns = [
{
- text: gettext("Source"),
+ text: gettext('Source'),
xtype: 'widgetcolumn',
dataIndex: 'source',
flex: 1,
@@ -97,7 +97,7 @@ Ext.define('PVE.sdn.Fabric.RedistributionGrid', {
},
},
{
- text: gettext("Route Map"),
+ text: gettext('Route Map'),
xtype: 'widgetcolumn',
dataIndex: 'route-map',
flex: 1,
@@ -108,7 +108,7 @@ Ext.define('PVE.sdn.Fabric.RedistributionGrid', {
},
...me.getAdditionalColumns(),
{
- text: gettext("Action"),
+ text: gettext('Action'),
xtype: 'actioncolumn',
width: 100,
items: [
@@ -124,28 +124,31 @@ Ext.define('PVE.sdn.Fabric.RedistributionGrid', {
me.callParent();
},
- isEqual: function(value1, value2) {
+ isEqual: function (value1, value2) {
return JSON.stringify(value1) === JSON.stringify(value2);
},
- getValue: function() {
+ getValue: function () {
let me = this;
- return me.getStore().getData().items.map((record) => {
- let data = {};
+ return me
+ .getStore()
+ .getData()
+ .items.map((record) => {
+ let data = {};
- for (const [key, value] of Object.entries(record.data)) {
- if (value === '' || value === undefined || value === null || key === 'id') {
- continue;
+ for (const [key, value] of Object.entries(record.data)) {
+ if (value === '' || value === undefined || value === null || key === 'id') {
+ continue;
+ }
+ data[key] = value;
}
- data[key] = value;
- }
- return PVE.Parser.printPropertyString(data, undefined);
- });
+ return PVE.Parser.printPropertyString(data, undefined);
+ });
},
- setValue: function(value) {
+ setValue: function (value) {
let me = this;
me.getStore().setData((value ?? []).map((item) => PVE.Parser.parsePropertyString(item)));
@@ -169,7 +172,7 @@ Ext.define('PVE.sdn.Fabric.RedistributionGrid', {
};
},
- getErrors: function(value) {
+ getErrors: function (value) {
let me = this;
let errors = [];
@@ -185,5 +188,5 @@ Ext.define('PVE.sdn.Fabric.RedistributionGrid', {
}
return errors;
- }
+ },
});
diff --git a/www/manager6/sdn/fabrics/ospf/FabricEdit.js b/www/manager6/sdn/fabrics/ospf/FabricEdit.js
index 2f057b8e8..315c99193 100644
--- a/www/manager6/sdn/fabrics/ospf/FabricEdit.js
+++ b/www/manager6/sdn/fabrics/ospf/FabricEdit.js
@@ -46,6 +46,6 @@ Ext.define('PVE.sdn.Fabric.Ospf.Fabric.Edit', {
],
},
],
- }
+ },
],
});
diff --git a/www/manager6/sdn/fabrics/ospf/InterfacePanel.js b/www/manager6/sdn/fabrics/ospf/InterfacePanel.js
index 370137cba..3a47bd524 100644
--- a/www/manager6/sdn/fabrics/ospf/InterfacePanel.js
+++ b/www/manager6/sdn/fabrics/ospf/InterfacePanel.js
@@ -23,10 +23,10 @@ Ext.define('PVE.sdn.Fabric.Ospf.NetworkTypeSelector', {
store: {
fields: ['name'],
data: [
- {name: 'broadcast'},
- {name: 'non-broadcast'},
- {name: 'point-to-multipoint'},
- {name: 'point-to-point'},
+ { name: 'broadcast' },
+ { name: 'non-broadcast' },
+ { name: 'point-to-multipoint' },
+ { name: 'point-to-point' },
],
},
});
--
2.47.3
next reply other threads:[~2026-05-15 9:24 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-05-15 9:23 Shannon Sterz [this message]
2026-05-15 9:33 ` applied: [PATCH manager] ui: run make tidy Thomas Lamprecht
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260515092331.86703-1-s.sterz@proxmox.com \
--to=s.sterz@proxmox.com \
--cc=pve-devel@lists.proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.