* [PATCH network] sdn: include fabrics when checking for pending changes
@ 2026-05-07 13:09 Gabriel Goller
2026-05-13 3:08 ` applied: " Thomas Lamprecht
0 siblings, 1 reply; 2+ messages in thread
From: Gabriel Goller @ 2026-05-07 13:09 UTC (permalink / raw)
To: pve-devel
The lock api endpoint uses `has_pending_changes` to determine whether
the SDN configuration can be locked. Previously, the fabric config was
not included in the check, allowing a config with pending fabric changes
to be locked.
Reported-by: Stefan Hanreich <s.hanreich@proxmox.com>
Signed-off-by: Gabriel Goller <g.goller@proxmox.com>
---
src/PVE/Network/SDN.pm | 1 +
1 file changed, 1 insertion(+)
diff --git a/src/PVE/Network/SDN.pm b/src/PVE/Network/SDN.pm
index fcb0f97c339b..33a3cf352496 100644
--- a/src/PVE/Network/SDN.pm
+++ b/src/PVE/Network/SDN.pm
@@ -252,6 +252,7 @@ sub has_pending_changes {
vnets => PVE::Network::SDN::Vnets::config(),
subnets => PVE::Network::SDN::Subnets::config(),
controllers => PVE::Network::SDN::Controllers::config(),
+ fabrics => { ids => PVE::Network::SDN::Fabrics::config()->to_sections() },
'route-maps' => { ids => PVE::Network::SDN::RouteMaps::config()->to_sections() },
'prefix-lists' => { ids => PVE::Network::SDN::PrefixLists::config()->to_sections() },
};
--
2.47.3
^ permalink raw reply related [flat|nested] 2+ messages in thread
* applied: [PATCH network] sdn: include fabrics when checking for pending changes
2026-05-07 13:09 [PATCH network] sdn: include fabrics when checking for pending changes Gabriel Goller
@ 2026-05-13 3:08 ` Thomas Lamprecht
0 siblings, 0 replies; 2+ messages in thread
From: Thomas Lamprecht @ 2026-05-13 3:08 UTC (permalink / raw)
To: pve-devel, Gabriel Goller
On Thu, 07 May 2026 15:09:56 +0200, Gabriel Goller wrote:
> The lock api endpoint uses `has_pending_changes` to determine whether
> the SDN configuration can be locked. Previously, the fabric config was
> not included in the check, allowing a config with pending fabric changes
> to be locked.
Applied, thanks!
[1/1] sdn: include fabrics when checking for pending changes
commit: b6156a57b60d596a247f7d385beb8a9a60ae3d5c
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2026-05-13 3:08 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2026-05-07 13:09 [PATCH network] sdn: include fabrics when checking for pending changes Gabriel Goller
2026-05-13 3:08 ` applied: " Thomas Lamprecht
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.