From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) by lore.proxmox.com (Postfix) with ESMTPS id 9A1A11FF13F for ; Thu, 07 May 2026 15:10:12 +0200 (CEST) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id 80CB51C3A3; Thu, 7 May 2026 15:10:11 +0200 (CEST) From: Gabriel Goller To: pve-devel@lists.proxmox.com Subject: [PATCH network] sdn: include fabrics when checking for pending changes Date: Thu, 7 May 2026 15:09:56 +0200 Message-ID: <20260507131000.304156-1-g.goller@proxmox.com> X-Mailer: git-send-email 2.47.3 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Bm-Milter-Handled: 55990f41-d878-4baa-be0a-ee34c49e34d2 X-Bm-Transport-Timestamp: 1778159296310 X-SPAM-LEVEL: Spam detection results: 0 AWL 0.029 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Message-ID-Hash: RXC4MDGOHL4FDOH7QTCFSU5QWWCOR4SX X-Message-ID-Hash: RXC4MDGOHL4FDOH7QTCFSU5QWWCOR4SX X-MailFrom: g.goller@proxmox.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; loop; banned-address; emergency; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header X-Mailman-Version: 3.3.10 Precedence: list List-Id: Proxmox VE development discussion List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: The lock api endpoint uses `has_pending_changes` to determine whether the SDN configuration can be locked. Previously, the fabric config was not included in the check, allowing a config with pending fabric changes to be locked. Reported-by: Stefan Hanreich Signed-off-by: Gabriel Goller --- src/PVE/Network/SDN.pm | 1 + 1 file changed, 1 insertion(+) diff --git a/src/PVE/Network/SDN.pm b/src/PVE/Network/SDN.pm index fcb0f97c339b..33a3cf352496 100644 --- a/src/PVE/Network/SDN.pm +++ b/src/PVE/Network/SDN.pm @@ -252,6 +252,7 @@ sub has_pending_changes { vnets => PVE::Network::SDN::Vnets::config(), subnets => PVE::Network::SDN::Subnets::config(), controllers => PVE::Network::SDN::Controllers::config(), + fabrics => { ids => PVE::Network::SDN::Fabrics::config()->to_sections() }, 'route-maps' => { ids => PVE::Network::SDN::RouteMaps::config()->to_sections() }, 'prefix-lists' => { ids => PVE::Network::SDN::PrefixLists::config()->to_sections() }, }; -- 2.47.3