Re: [PATCH pve-manager] api: sdn: dns: fix double slash in delete request

[David Riley <d.riley@proxmox.com>]

Thanks for the feedback. I've just sent a v3 to the list that
incorporates the improved wording and the RFC context.

I missed your earlier response because it was sent to the
list only rather than via reply-all, so I had already
dispatched v2 by the time I saw it. The v3 now
consolidates everything.

On 4/28/26 11:56 AM, Nicolas Frey wrote:
> Thanks for the patch! minor nit about the commit message:
>
> although it's not incorrect that this fixes/removes the double slash
> in the delete request, the code change would IMO be better described by:
>
> 'remove trailing slash in delete request'
>
> as that is what the code reads as, with extra context as to *why* it
> is done in the body, e.g. something like:
>
> "
> Fixes delete request containing double slashes (//), resulting in a
> URI like `/sdn/dns//<dns>`. Although this gets normalized on the
> server, a strict firewall/proxy might cause problems.
> "
>
> as a side note: according to RFC 2396, a path may only consist of a
> single slash [0]
>
> [0] https://www.rfc-editor.org/rfc/rfc2396#section-3.3
>
>
> On 4/28/26 11:30 AM, David Riley wrote:
>> Fix the deletion request for DNS options which contained a double
>> slash (//), resulting in a URI like /sdn/dns//<dns>. Even though
>> the server normalized this and the request succeeded, cleaning it
>> up avoids potential issues with strict reverse proxies or firewalls.
>>
>> Signed-off-by: David Riley <d.riley@proxmox.com>
>> ---
>>   www/manager6/sdn/DnsView.js | 2 +-
>>   1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/www/manager6/sdn/DnsView.js b/www/manager6/sdn/DnsView.js
>> index ba5ada5a..c5cd32bb 100644
>> --- a/www/manager6/sdn/DnsView.js
>> +++ b/www/manager6/sdn/DnsView.js
>> @@ -59,7 +59,7 @@ Ext.define('PVE.sdn.DnsView', {
>>   
>>           let remove_btn = Ext.create('Proxmox.button.StdRemoveButton', {
>>               selModel: sm,
>> -            baseurl: '/cluster/sdn/dns/',
>> +            baseurl: '/cluster/sdn/dns',
>>               callback: () => store.load(),
>>           });
>>   
>
>
>
>