all lists on lists.proxmox.com
 help / color / mirror / Atom feed
From: David Riley <d.riley@proxmox.com>
To: pve-devel@lists.proxmox.com
Cc: David Riley <d.riley@proxmox.com>
Subject: [PATCH pve-manager] api: sdn: dns: fix double slash in delete request
Date: Tue, 28 Apr 2026 11:31:30 +0200	[thread overview]
Message-ID: <20260428093130.44753-1-d.riley@proxmox.com> (raw)

Fix the deletion request for DNS options which contained a double
slash (//), resulting in a URI like /sdn/dns//<dns>. Even though
the server normalized this and the request succeeded, cleaning it
up avoids potential issues with strict reverse proxies or firewalls.

Signed-off-by: David Riley <d.riley@proxmox.com>
---
 www/manager6/sdn/DnsView.js | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/www/manager6/sdn/DnsView.js b/www/manager6/sdn/DnsView.js
index ba5ada5a..c5cd32bb 100644
--- a/www/manager6/sdn/DnsView.js
+++ b/www/manager6/sdn/DnsView.js
@@ -59,7 +59,7 @@ Ext.define('PVE.sdn.DnsView', {
 
         let remove_btn = Ext.create('Proxmox.button.StdRemoveButton', {
             selModel: sm,
-            baseurl: '/cluster/sdn/dns/',
+            baseurl: '/cluster/sdn/dns',
             callback: () => store.load(),
         });
 
-- 
2.47.3





             reply	other threads:[~2026-04-28  9:32 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-04-28  9:31 David Riley [this message]
2026-04-28  9:57 ` [PATCH pve-manager] api: sdn: dns: fix double slash in delete request Nicolas Frey
2026-04-28 12:25   ` David Riley
2026-04-28 11:42 ` David Riley

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20260428093130.44753-1-d.riley@proxmox.com \
    --to=d.riley@proxmox.com \
    --cc=pve-devel@lists.proxmox.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.
Service provided by Proxmox Server Solutions GmbH | Privacy | Legal