From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [IPv6:2a01:7e0:0:424::9]) by lore.proxmox.com (Postfix) with ESMTPS id E697E1FF146 for ; Tue, 28 Apr 2026 14:25:14 +0200 (CEST) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id BA66411AF4; Tue, 28 Apr 2026 14:25:14 +0200 (CEST) Message-ID: <09a4ed83-4e12-40a4-9165-ba46edd7c6ff@proxmox.com> Date: Tue, 28 Apr 2026 14:25:10 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH pve-manager] api: sdn: dns: fix double slash in delete request To: Nicolas Frey , pve-devel@lists.proxmox.com References: <20260428093130.44753-1-d.riley@proxmox.com> Content-Language: en-US From: David Riley In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Bm-Milter-Handled: 55990f41-d878-4baa-be0a-ee34c49e34d2 X-Bm-Transport-Timestamp: 1777379014267 X-SPAM-LEVEL: Spam detection results: 0 AWL 0.468 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Message-ID-Hash: VAQTI7SZ65BKCTW2UFIKFN6VBPIJ7IBC X-Message-ID-Hash: VAQTI7SZ65BKCTW2UFIKFN6VBPIJ7IBC X-MailFrom: d.riley@proxmox.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; loop; banned-address; emergency; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header X-Mailman-Version: 3.3.10 Precedence: list List-Id: Proxmox VE development discussion List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: Thanks for the feedback. I've just sent a v3 to the list that incorporates the improved wording and the RFC context. I missed your earlier response because it was sent to the list only rather than via reply-all, so I had already dispatched v2 by the time I saw it. The v3 now consolidates everything. On 4/28/26 11:56 AM, Nicolas Frey wrote: > Thanks for the patch! minor nit about the commit message: > > although it's not incorrect that this fixes/removes the double slash > in the delete request, the code change would IMO be better described by: > > 'remove trailing slash in delete request' > > as that is what the code reads as, with extra context as to *why* it > is done in the body, e.g. something like: > > " > Fixes delete request containing double slashes (//), resulting in a > URI like `/sdn/dns//`. Although this gets normalized on the > server, a strict firewall/proxy might cause problems. > " > > as a side note: according to RFC 2396, a path may only consist of a > single slash [0] > > [0] https://www.rfc-editor.org/rfc/rfc2396#section-3.3 > > > On 4/28/26 11:30 AM, David Riley wrote: >> Fix the deletion request for DNS options which contained a double >> slash (//), resulting in a URI like /sdn/dns//. Even though >> the server normalized this and the request succeeded, cleaning it >> up avoids potential issues with strict reverse proxies or firewalls. >> >> Signed-off-by: David Riley >> --- >> www/manager6/sdn/DnsView.js | 2 +- >> 1 file changed, 1 insertion(+), 1 deletion(-) >> >> diff --git a/www/manager6/sdn/DnsView.js b/www/manager6/sdn/DnsView.js >> index ba5ada5a..c5cd32bb 100644 >> --- a/www/manager6/sdn/DnsView.js >> +++ b/www/manager6/sdn/DnsView.js >> @@ -59,7 +59,7 @@ Ext.define('PVE.sdn.DnsView', { >> >> let remove_btn = Ext.create('Proxmox.button.StdRemoveButton', { >> selModel: sm, >> - baseurl: '/cluster/sdn/dns/', >> + baseurl: '/cluster/sdn/dns', >> callback: () => store.load(), >> }); >> > > > >