From: Maximiliano Sandoval <m.sandoval@proxmox.com>
To: Shannon Sterz <s.sterz@proxmox.com>
Cc: yew-devel@lists.proxmox.com
Subject: Re: [yew-devel] [PATCH yew-comp] token panel: ask for confirmation when removing a token
Date: Thu, 23 Oct 2025 15:23:57 +0200 [thread overview]
Message-ID: <s8owm4lvjiq.fsf@proxmox.com> (raw)
In-Reply-To: <20251023080013.40452-1-s.sterz@proxmox.com> (Shannon Sterz's message of "Thu, 23 Oct 2025 10:00:13 +0200")
Shannon Sterz <s.sterz@proxmox.com> writes:
> by using a `ConfirmButton` instead of just a `Button`.
>
> Signed-off-by: Shannon Sterz <s.sterz@proxmox.com>
> ---
> src/token_panel.rs | 4 +++-
> 1 file changed, 3 insertions(+), 1 deletion(-)
>
> diff --git a/src/token_panel.rs b/src/token_panel.rs
> index 55795a6..d61063a 100644
> --- a/src/token_panel.rs
> +++ b/src/token_panel.rs
> @@ -190,7 +190,9 @@ impl LoadableComponent for ProxmoxTokenView {
> .on_activate(link.change_view_callback(|_| Some(ViewState::EditToken))),
> )
> .with_child(
> - Button::new(tr!("Remove"))
> + ConfirmButton::new(tr!("Remove"))
> + .confirm_message(tr!("Are you sure you want to remove the API token? \
> + All current usage sites will lose access!"))
I know this label is used already in other places and this is
pre-existing, but I am not sure if "usage sites" is easy to understand.
Perhaps something along the lines of "All users of the token will lose
access" is more straightforward.
> .disabled(disabled)
> .on_activate(link.callback(|_| Msg::Remove)),
> )
--
Maximiliano
_______________________________________________
yew-devel mailing list
yew-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/yew-devel
next prev parent reply other threads:[~2025-10-23 13:23 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-10-23 8:00 Shannon Sterz
2025-10-23 13:23 ` Maximiliano Sandoval [this message]
2025-10-23 14:46 ` [yew-devel] Superseded: " Shannon Sterz
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=s8owm4lvjiq.fsf@proxmox.com \
--to=m.sandoval@proxmox.com \
--cc=s.sterz@proxmox.com \
--cc=yew-devel@lists.proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox