[yew-devel] [PATCH yew-comp] delete_empty_values: use array instead of string-list

[yew-devel] [PATCH yew-comp] delete_empty_values: use array instead of string-list

[Hannes Laimer]

PVE does accept arrays since [1], and with [2] PDM expects arrays.

[1] pve-common 69d9edcc ("section config: implement array support")
[2] proxmox bd8eca6b ("pve-api-types: schema2rust: generate arrays for types with format `-list`")

Signed-off-by: Hannes Laimer <h.laimer@proxmox.com>
---
This was somewhat recently changed to a string-list, but with the recent
change in the PVE type generation we need an actual array here.

 src/form/mod.rs | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/src/form/mod.rs b/src/form/mod.rs
index 6a92a90..0c23053 100644
--- a/src/form/mod.rs
+++ b/src/form/mod.rs
@@ -44,7 +44,7 @@ pub fn delete_empty_values(record: &Value, param_list: &[&str], delete_undefined
     }
 
     if !delete.is_empty() {
-        new["delete"] = delete.join(",").into();
+        new["delete"] = delete.into();
     }
 
     new
-- 
2.47.3



_______________________________________________
yew-devel mailing list
yew-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/yew-devel

Re: [yew-devel] [PATCH yew-comp] delete_empty_values: use array instead of string-list

[Thomas Lamprecht]

Am 29.10.25 um 18:35 schrieb Hannes Laimer:
> PVE does accept arrays since [1], and with [2] PDM expects arrays.
> 
> [1] pve-common 69d9edcc ("section config: implement array support")
> [2] proxmox bd8eca6b ("pve-api-types: schema2rust: generate arrays for types with format `-list`")
> 
> Signed-off-by: Hannes Laimer <h.laimer@proxmox.com>
> ---
> This was somewhat recently changed to a string-list, but with the recent
> change in the PVE type generation we need an actual array here.

For the record: This is now obsolete again as Dietmar pushed a similar patch
recently directly:

https://git.proxmox.com/?p=ui/proxmox-yew-comp.git;a=commitdiff;h=e3e2cc5eb8c75c119dd5dea909b522ccfb7701b7;hp=fa71a6b2c5002b65fa91bd7005150faf4d9646aa


_______________________________________________
yew-devel mailing list
yew-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/yew-devel

Re: [yew-devel] [PATCH yew-comp] delete_empty_values: use array instead of string-list

[Hannes Laimer]

On 11/6/25 21:46, Thomas Lamprecht wrote:
> Am 29.10.25 um 18:35 schrieb Hannes Laimer:
>> PVE does accept arrays since [1], and with [2] PDM expects arrays.
>>
>> [1] pve-common 69d9edcc ("section config: implement array support")
>> [2] proxmox bd8eca6b ("pve-api-types: schema2rust: generate arrays for types with format `-list`")
>>
>> Signed-off-by: Hannes Laimer <h.laimer@proxmox.com>
>> ---
>> This was somewhat recently changed to a string-list, but with the recent
>> change in the PVE type generation we need an actual array here.
> 
> For the record: This is now obsolete again as Dietmar pushed a similar patch
> recently directly:
> 
> https://git.proxmox.com/?p=ui/proxmox-yew-comp.git;a=commitdiff;h=e3e2cc5eb8c75c119dd5dea909b522ccfb7701b7;hp=fa71a6b2c5002b65fa91bd7005150faf4d9646aa

good to know :P I think I did reference this in a series for PDM.
Thanks for taking a look!



_______________________________________________
yew-devel mailing list
yew-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/yew-devel