From: Hannes Laimer <h.laimer@proxmox.com>
To: Thomas Lamprecht <t.lamprecht@proxmox.com>,
Yew framework devel list at Proxmox <yew-devel@lists.proxmox.com>
Subject: Re: [yew-devel] [PATCH yew-comp] delete_empty_values: use array instead of string-list
Date: Fri, 7 Nov 2025 08:00:11 +0100 [thread overview]
Message-ID: <ac46fb9f-560a-4e24-ad78-99c30c472f69@proxmox.com> (raw)
In-Reply-To: <d81bfe04-6db4-4265-923e-3c95d6e93d03@proxmox.com>
On 11/6/25 21:46, Thomas Lamprecht wrote:
> Am 29.10.25 um 18:35 schrieb Hannes Laimer:
>> PVE does accept arrays since [1], and with [2] PDM expects arrays.
>>
>> [1] pve-common 69d9edcc ("section config: implement array support")
>> [2] proxmox bd8eca6b ("pve-api-types: schema2rust: generate arrays for types with format `-list`")
>>
>> Signed-off-by: Hannes Laimer <h.laimer@proxmox.com>
>> ---
>> This was somewhat recently changed to a string-list, but with the recent
>> change in the PVE type generation we need an actual array here.
>
> For the record: This is now obsolete again as Dietmar pushed a similar patch
> recently directly:
>
> https://git.proxmox.com/?p=ui/proxmox-yew-comp.git;a=commitdiff;h=e3e2cc5eb8c75c119dd5dea909b522ccfb7701b7;hp=fa71a6b2c5002b65fa91bd7005150faf4d9646aa
good to know :P I think I did reference this in a series for PDM.
Thanks for taking a look!
_______________________________________________
yew-devel mailing list
yew-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/yew-devel
prev parent reply other threads:[~2025-11-07 7:00 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-10-29 17:35 Hannes Laimer
2025-11-06 20:46 ` Thomas Lamprecht
2025-11-07 7:00 ` Hannes Laimer [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ac46fb9f-560a-4e24-ad78-99c30c472f69@proxmox.com \
--to=h.laimer@proxmox.com \
--cc=t.lamprecht@proxmox.com \
--cc=yew-devel@lists.proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox