public inbox for yew-devel@lists.proxmox.com
 help / color / mirror / Atom feed
From: "Shannon Sterz" <s.sterz@proxmox.com>
To: "Shannon Sterz" <s.sterz@proxmox.com>, <yew-devel@lists.proxmox.com>
Subject: Re: [PATCH yew-mobile-gui 15/20] lxc page: align layout for lxc guest with qemu guests
Date: Fri, 08 May 2026 17:43:44 +0200	[thread overview]
Message-ID: <DIDESOI7HE8B.2G76VI8E4PAS0@proxmox.com> (raw)
In-Reply-To: <20260508150535.420205-16-s.sterz@proxmox.com>

On Fri May 8, 2026 at 5:05 PM CEST, Shannon Sterz wrote:
> by adding icons and scrolling to the top-level tab panel
>
> Signed-off-by: Shannon Sterz <s.sterz@proxmox.com>
> ---
>  src/pages/page_lxc_status/mod.rs | 24 ++++++++++++++++++------
>  1 file changed, 18 insertions(+), 6 deletions(-)
>
> diff --git a/src/pages/page_lxc_status/mod.rs b/src/pages/page_lxc_status/mod.rs
> index 97ebddf..4092dd5 100644
> --- a/src/pages/page_lxc_status/mod.rs
> +++ b/src/pages/page_lxc_status/mod.rs
> @@ -1,5 +1,6 @@
>  use std::rc::Rc;
>
> +use pwt::css::Flex;
>  use pwt::props::StorageLocation;
>  use serde::{Deserialize, Serialize};
>
> @@ -8,7 +9,7 @@ use yew::virtual_dom::{VComp, VNode};
>
>  use pwt::prelude::*;
>  use pwt::state::PersistentState;
> -use pwt::widget::{Column, TabBar, TabBarItem};
> +use pwt::widget::{Column, MiniScroll, TabBar, TabBarItem};
>
>  use crate::widgets::{GuestBackupPanel, TopNavBar};
>
> @@ -95,10 +96,12 @@ impl Component for PvePageLxcStatus {
>
>          let tab_bar = TabBar::new()
>              .class(pwt::css::JustifyContent::Center)
> +            .class(Flex::Fill)
>              .active(active_tab)
>              .with_item(
>                  TabBarItem::new()
>                      .label("Dashboard")
> +                    .icon_class("fa fa-book")
>                      .key("dashboard")
>                      .on_activate(
>                          ctx.link()
> @@ -108,6 +111,7 @@ impl Component for PvePageLxcStatus {
>              .with_item(
>                  TabBarItem::new()
>                      .label("Options")
> +                    .icon_class("fa fa-floppy-o")

i just noticed that the icons for "Options" and "Backup" should probably
be switched. this was copied over from the qemu panel, i'll send a
commit fixing that for both components in a minute. if a v2 becomes
necessary i'll in-line that patch for this component here.

>                      .key("options")
>                      .on_activate(
>                          ctx.link()
> @@ -115,10 +119,14 @@ impl Component for PvePageLxcStatus {
>                      ),
>              )
>              .with_item(
> -                TabBarItem::new().label("Backup").key("backup").on_activate(
> -                    ctx.link()
> -                        .callback(|_| Msg::SetViewState(ViewState::Backup)),
> -                ),
> +                TabBarItem::new()
> +                    .label("Backup")
> +                    .icon_class("fa fa-gear")
> +                    .key("backup")
> +                    .on_activate(
> +                        ctx.link()
> +                            .callback(|_| Msg::SetViewState(ViewState::Backup)),
> +                    ),
>              );
>
>          Column::new()
> @@ -128,7 +136,11 @@ impl Component for PvePageLxcStatus {
>                      .title(format!("CT {}", props.vmid))
>                      .back("/resources"),
>              )
> -            .with_child(tab_bar)
> +            .with_child(
> +                MiniScroll::new(tab_bar)
> +                    .class(Flex::None)
> +                    .scroll_mode(pwt::widget::MiniScrollMode::Native),
> +            )
>              .with_child(content)
>              .into()
>      }





  reply	other threads:[~2026-05-08 15:44 UTC|newest]

Thread overview: 24+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-05-08 15:05 [PATCH yew-comp/yew-mobile-gui 00/20] firewall tabs and clean up for pve-yew-mobile-gui Shannon Sterz
2026-05-08 15:05 ` [PATCH yew-comp 01/20] firewall rules panel: correct the url for the pve cluster firewall rules Shannon Sterz
2026-05-08 15:05 ` [PATCH yew-mobile-gui 02/20] cargo.toml: globally ignore certain clippy lints Shannon Sterz
2026-05-08 15:05 ` [PATCH yew-mobile-gui 03/20] main: avoid unnecessary clones Shannon Sterz
2026-05-08 15:05 ` [PATCH yew-mobile-gui 04/20] tree-wide: collapse if statements Shannon Sterz
2026-05-08 15:05 ` [PATCH yew-mobile-gui 05/20] tree-wide: implement the `From` trait instead of the `Into` trait Shannon Sterz
2026-05-08 15:05 ` [PATCH yew-mobile-gui 06/20] tree-wide: implement `Default` for types with an `new()` constructor Shannon Sterz
2026-05-08 15:05 ` [PATCH yew-mobile-gui 07/20] tree-wide: remove unnecessary lazy evaluations Shannon Sterz
2026-05-08 15:05 ` [PATCH yew-mobile-gui 08/20] tree-wide: remove needless borrows Shannon Sterz
2026-05-08 15:05 ` [PATCH yew-mobile-gui 09/20] configuration page: remove redundant static lifetimes Shannon Sterz
2026-05-08 15:05 ` [PATCH yew-mobile-gui 10/20] resources/configuration page: remove useless `.into()` calls Shannon Sterz
2026-05-08 15:05 ` [PATCH yew-mobile-gui 11/20] tree-wide: fix several clippy lints Shannon Sterz
2026-05-08 15:05 ` [PATCH yew-mobile-gui 12/20] dashboard: use proper plural translation string instead of "CPU(s)" Shannon Sterz
2026-05-08 15:05 ` [PATCH yew-mobile-gui 13/20] configuration: clarify that "Firewall" shows the cluster's firewall Shannon Sterz
2026-05-08 15:05 ` [PATCH yew-mobile-gui 14/20] cluster/qemu firewall: use rules panel and comment out unused tabs Shannon Sterz
2026-05-08 15:05 ` [PATCH yew-mobile-gui 15/20] lxc page: align layout for lxc guest with qemu guests Shannon Sterz
2026-05-08 15:43   ` Shannon Sterz [this message]
2026-05-08 15:05 ` [PATCH yew-mobile-gui 16/20] lxc: add support for a rudimentary firewall tab for lxc guests Shannon Sterz
2026-05-08 15:05 ` [PATCH yew-mobile-gui 17/20] node status: align layout for node status with guest pages Shannon Sterz
2026-05-08 15:05 ` [PATCH yew-mobile-gui 18/20] node: add a rudimentary firewall tab for cluster nodes Shannon Sterz
2026-05-08 15:05 ` [PATCH yew-mobile-gui 19/20] api types: remove unused file Shannon Sterz
2026-05-08 15:05 ` [PATCH yew-mobile-gui 20/20] resources page: map subscription level analogous to dashboard Shannon Sterz
2026-05-08 15:22   ` Shan Shaji
2026-05-08 15:59 ` Superseded: Re: [PATCH yew-comp/yew-mobile-gui 00/20] firewall tabs and clean up for pve-yew-mobile-gui Shannon Sterz

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=DIDESOI7HE8B.2G76VI8E4PAS0@proxmox.com \
    --to=s.sterz@proxmox.com \
    --cc=yew-devel@lists.proxmox.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Service provided by Proxmox Server Solutions GmbH | Privacy | Legal