From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) by lore.proxmox.com (Postfix) with ESMTPS id 611F21FF14F for ; Fri, 08 May 2026 17:44:22 +0200 (CEST) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id E02ED1D27B; Fri, 8 May 2026 17:44:21 +0200 (CEST) Mime-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset=UTF-8 Date: Fri, 08 May 2026 17:43:44 +0200 Message-Id: To: "Shannon Sterz" , Subject: Re: [PATCH yew-mobile-gui 15/20] lxc page: align layout for lxc guest with qemu guests X-Mailer: aerc 0.20.0 References: <20260508150535.420205-1-s.sterz@proxmox.com> <20260508150535.420205-16-s.sterz@proxmox.com> In-Reply-To: <20260508150535.420205-16-s.sterz@proxmox.com> From: "Shannon Sterz" X-Bm-Milter-Handled: 55990f41-d878-4baa-be0a-ee34c49e34d2 X-Bm-Transport-Timestamp: 1778254915669 X-SPAM-LEVEL: Spam detection results: 0 AWL 0.117 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Message-ID-Hash: 4AILYIH7FPKD6TGLHDPWBJLJXPTJQ4XK X-Message-ID-Hash: 4AILYIH7FPKD6TGLHDPWBJLJXPTJQ4XK X-MailFrom: s.sterz@proxmox.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; loop; banned-address; emergency; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header X-Mailman-Version: 3.3.10 Precedence: list List-Id: Yew framework devel list at Proxmox List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: On Fri May 8, 2026 at 5:05 PM CEST, Shannon Sterz wrote: > by adding icons and scrolling to the top-level tab panel > > Signed-off-by: Shannon Sterz > --- > src/pages/page_lxc_status/mod.rs | 24 ++++++++++++++++++------ > 1 file changed, 18 insertions(+), 6 deletions(-) > > diff --git a/src/pages/page_lxc_status/mod.rs b/src/pages/page_lxc_status= /mod.rs > index 97ebddf..4092dd5 100644 > --- a/src/pages/page_lxc_status/mod.rs > +++ b/src/pages/page_lxc_status/mod.rs > @@ -1,5 +1,6 @@ > use std::rc::Rc; > > +use pwt::css::Flex; > use pwt::props::StorageLocation; > use serde::{Deserialize, Serialize}; > > @@ -8,7 +9,7 @@ use yew::virtual_dom::{VComp, VNode}; > > use pwt::prelude::*; > use pwt::state::PersistentState; > -use pwt::widget::{Column, TabBar, TabBarItem}; > +use pwt::widget::{Column, MiniScroll, TabBar, TabBarItem}; > > use crate::widgets::{GuestBackupPanel, TopNavBar}; > > @@ -95,10 +96,12 @@ impl Component for PvePageLxcStatus { > > let tab_bar =3D TabBar::new() > .class(pwt::css::JustifyContent::Center) > + .class(Flex::Fill) > .active(active_tab) > .with_item( > TabBarItem::new() > .label("Dashboard") > + .icon_class("fa fa-book") > .key("dashboard") > .on_activate( > ctx.link() > @@ -108,6 +111,7 @@ impl Component for PvePageLxcStatus { > .with_item( > TabBarItem::new() > .label("Options") > + .icon_class("fa fa-floppy-o") i just noticed that the icons for "Options" and "Backup" should probably be switched. this was copied over from the qemu panel, i'll send a commit fixing that for both components in a minute. if a v2 becomes necessary i'll in-line that patch for this component here. > .key("options") > .on_activate( > ctx.link() > @@ -115,10 +119,14 @@ impl Component for PvePageLxcStatus { > ), > ) > .with_item( > - TabBarItem::new().label("Backup").key("backup").on_activ= ate( > - ctx.link() > - .callback(|_| Msg::SetViewState(ViewState::Backu= p)), > - ), > + TabBarItem::new() > + .label("Backup") > + .icon_class("fa fa-gear") > + .key("backup") > + .on_activate( > + ctx.link() > + .callback(|_| Msg::SetViewState(ViewState::B= ackup)), > + ), > ); > > Column::new() > @@ -128,7 +136,11 @@ impl Component for PvePageLxcStatus { > .title(format!("CT {}", props.vmid)) > .back("/resources"), > ) > - .with_child(tab_bar) > + .with_child( > + MiniScroll::new(tab_bar) > + .class(Flex::None) > + .scroll_mode(pwt::widget::MiniScrollMode::Native), > + ) > .with_child(content) > .into() > }