From: "Christoph Heiss" <c.heiss@proxmox.com>
To: "Dominik Csapak" <d.csapak@proxmox.com>
Cc: yew-devel@lists.proxmox.com
Subject: Re: [RFC PATCH yew-widget-toolkit 1/2] widget: form: number: round floats to nearest step value
Date: Wed, 25 Mar 2026 13:09:34 +0100 [thread overview]
Message-ID: <DHBUOQJBR85Z.3D93A9D4N7C60@proxmox.com> (raw)
In-Reply-To: <57e99cba-a8c3-4ff4-ba49-87352877ad64@proxmox.com>
Thanks for taking a look!
On Mon Mar 23, 2026 at 9:51 AM CET, Dominik Csapak wrote:
> my first instinct would have been to simply change the formatting to
> round to some value of precision but you're right that it's just masking
> the symptom.
>
> but I think this patch is also missing some parts. I think
> ideally we want to have a 'decimalPrecision' property that controls
> the value also on setting/reading, change event etc.
> (like it exists in ExtJS)
>
> that should by default use a sensible value (like you did here
> with 100_000 it can be just '5')
>
> what do you think?
Yeah, I was thinking about that too briefly. Would be bit more effort,
but sure, definitely makes sense!
I'll spin a v2 with that, mostly wanted to get some early feedback with
this patch, whether the overall approach of this fix is acceptable.
next prev parent reply other threads:[~2026-03-25 12:09 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-03-19 17:04 [PATCH yew-widget-toolkit 0/2] widget: form: number: fix float display and focus Christoph Heiss
2026-03-19 17:04 ` [RFC PATCH yew-widget-toolkit 1/2] widget: form: number: round floats to nearest step value Christoph Heiss
2026-03-23 8:51 ` Dominik Csapak
2026-03-25 12:09 ` Christoph Heiss [this message]
2026-03-19 17:04 ` [PATCH yew-widget-toolkit 2/2] widget: form: number: allow focusing the input on click Christoph Heiss
2026-03-23 8:54 ` Dominik Csapak
2026-03-23 10:43 ` Dietmar Maurer
2026-03-23 8:50 ` partially applied: [PATCH yew-widget-toolkit 0/2] widget: form: number: fix float display and focus Dominik Csapak
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=DHBUOQJBR85Z.3D93A9D4N7C60@proxmox.com \
--to=c.heiss@proxmox.com \
--cc=d.csapak@proxmox.com \
--cc=yew-devel@lists.proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox