Re: [PATCH yew-comp v2 00/13] clippy clean up for proxmox-yew-comp

["Shannon Sterz" <s.sterz@proxmox.com>]

for reference, this series was applied:

https://git.proxmox.com/?p=ui/proxmox-yew-comp.git;a=commit;h=63a0d12e870f6edf40355edf02bfd025a4cdbafc

On Mon Mar 9, 2026 at 4:29 PM CET, Shannon Sterz wrote:
> these patches clean up all clippy warning in proxmox-yew-comp. see each
> patch for a description which lints are being cleaned up.
>
> changelog
> ---------
>
> changes since v1 (thanks @ Dominik Csapak):
> * cleaned up list of addressed clippy lints in commit 8 (tree wide: fix
>   various minor clippy lints)
> * instead of fixing or locally ignoring the lints "too_many_arguments",
>   "enum_variant_names", and "large_enum_variant", drop the respective
>   commits addressing them and add one that globally ignores them.
>
>
> Shannon Sterz (13):
>   tree wide: fix clippy lint "useless_conversion"
>   tree wide: fix clippy lint "new_without_default"
>   tree wide: fix clippy lint "redundant_static_lifetimes"
>   tree wide: fix clippy lint "unnecessary_lazy_evaluations"
>   tree wide: fix clippy lint "unwrap_or_default"
>   tree wide: fix clippy lint "clone_on_copy"
>   tree wide: fix clippy lint "collapsible_else_if"
>   tree wide: fix various minor clippy lints
>   tree wide: fix clippy lint "manual_strip"
>   lxc_property/qemu_property: fix clippy lint "match_like_matches_macro"
>   firewall_property: fix clippy lint "redundant_guards"
>   qemu_property: fix clippy lint "redundant_pattern_matching"
>   cargo.toml: globally ignore certain clippy lints
>
>  Cargo.toml                                    |  5 +
>  .../firewall_options_cluster_panel.rs         |  6 ++
>  .../pve/firewall/firewall_rules_panel.rs      |  4 +-
>  src/configuration/pve/lxc_network_panel.rs    | 15 ++-
>  .../pve/lxc_resources_panel/desktop.rs        |  4 +-
>  .../pve/lxc_resources_panel/mobile.rs         |  2 +-
>  .../reassign_volume_dialog.rs                 |  6 +-
>  src/configuration/pve/move_disk_dialog.rs     |  2 +-
>  .../pve/qemu_hardware_panel/desktop.rs        |  6 +-
>  .../pve/qemu_hardware_panel/mobile.rs         |  4 +-
>  .../reassign_disk_dialog.rs                   |  4 +-
>  src/editable_property.rs                      |  2 +-
>  src/form/pve/boot_device_list.rs              |  6 +-
>  .../firewall_property/log_level_selector.rs   |  6 ++
>  .../log_ratelimit_property.rs                 | 13 ++-
>  .../log_ratelimit_selector.rs                 | 12 ++-
>  src/form/pve/firewall_property/mod.rs         |  6 +-
>  src/form/pve/hotplug_feature_selector.rs      | 18 ++--
>  src/form/pve/lxc_mount_options_selector.rs    | 10 +-
>  .../pve/lxc_property/lxc_cores_property.rs    |  8 +-
>  .../pve/lxc_property/lxc_features_property.rs | 27 +++--
>  .../lxc_property/lxc_memory_swap_property.rs  |  4 +-
>  .../lxc_property/lxc_mount_point_property.rs  | 88 +++++++----------
>  .../lxc_property/lxc_nameserver_property.rs   |  4 +-
>  .../pve/lxc_property/lxc_network_property.rs  | 36 +++----
>  src/form/pve/mod.rs                           |  4 +-
>  src/form/pve/pve_guest_selector.rs            | 14 ++-
>  src/form/pve/pve_network_selector.rs          | 11 ++-
>  src/form/pve/pve_storage_content_selector.rs  | 12 ++-
>  src/form/pve/pve_vlan_field.rs                |  6 ++
>  src/form/pve/qemu_cache_type_selector.rs      |  6 ++
>  src/form/pve/qemu_controller_selector.rs      |  6 ++
>  src/form/pve/qemu_cpu_flags_list.rs           | 22 +++--
>  src/form/pve/qemu_disk_format_selector.rs     | 11 ++-
>  .../pve/qemu_disk_size_format_selector.rs     | 12 ++-
>  src/form/pve/qemu_display_type_selector.rs    |  6 ++
>  src/form/pve/qemu_machine_version_selector.rs | 18 ++--
>  src/form/pve/qemu_ostype_selector.rs          |  6 ++
>  src/form/pve/qemu_property/mod.rs             |  2 +-
>  .../qemu_property/qemu_amd_sev_property.rs    | 18 ++--
>  .../pve/qemu_property/qemu_disk_property.rs   | 99 +++++++++----------
>  .../qemu_property/qemu_display_property.rs    |  4 +-
>  .../qemu_property/qemu_efidisk_property.rs    | 11 +--
>  .../qemu_property/qemu_intel_tdx_property.rs  | 12 +--
>  .../pve/qemu_property/qemu_memory_property.rs | 17 ++--
>  .../qemu_property/qemu_processor_property.rs  |  4 +-
>  .../pve/qemu_property/qemu_scsihw_property.rs |  4 +-
>  .../qemu_property/qemu_smbios1_property.rs    |  2 +-
>  .../qemu_spice_enhancement_property.rs        |  4 +-
>  .../qemu_property/qemu_tpmstate_property.rs   |  4 +-
>  src/layout/mobile_form.rs                     |  4 +-
>  src/loadable_component.rs                     |  6 ++
>  src/log_view.rs                               |  2 +-
>  src/pending_property_view/mod.rs              |  6 ++
>  src/property_edit_dialog.rs                   |  4 +-
>  src/property_view/mod.rs                      |  6 +-
>  src/utils/task_descriptions.rs                |  4 +-
>  57 files changed, 356 insertions(+), 289 deletions(-)
>
> --
> 2.47.3