From: "Shan Shaji" <s.shaji@proxmox.com>
To: "Shan Shaji" <s.shaji@proxmox.com>,
"Thomas Lamprecht" <t.lamprecht@proxmox.com>,
"Yew framework devel list at Proxmox"
<yew-devel@lists.proxmox.com>
Subject: Re: [yew-devel] [PATCH proxmox-yew-comp] fix: use IEC standared for showing the HD space
Date: Tue, 10 Mar 2026 10:27:33 +0100 [thread overview]
Message-ID: <DGYZUIACGX8W.3GLREQLM8FB0K@proxmox.com> (raw)
In-Reply-To: <DGYZAYAHXFD4.UFLXFMKODZ8L@proxmox.com>
Ahh, sorry! Actually this got applied. I missed sending superseded for this patch.
https://lore.proxmox.com/yew-devel/mkgnf4mi.23pnmnzxvd400@proxmox.com/
On Tue Mar 10, 2026 at 10:02 AM CET, Shan Shaji wrote:
> On Mon Mar 9, 2026 at 10:22 PM CET, Thomas Lamprecht wrote:
>> Am 19.12.25 um 18:21 schrieb Shan Shaji:
>>> The HD space was being showing in SI unit, However all other metrics
>>> shown in the remote overview section were in IEC unit. Fixed it by
>>> updating it to use the IEC unit.
>>
>> But we do favor base-10 units for storage sizes and IEC for memory (and
>> bits for network traffic), so this would seem alright as is to me, or?
>
> Thank you Thomas. I was not aware about that. However, when i checked PVE,
> inside the summary section the HD space is shown in IEC unit. For PBS, the
> HD space under dashboard is in base-10. As for PDM, under the remote dasboard
> the "Host Storage used" is shown in IEC unit. I believe it's a bit inconsistent.
> I am not sure if that's expected. Shall i make it consistent across the products as
> you mentioned?
>
>>>
>>> Signed-off-by: Shan Shaji <s.shaji@proxmox.com>
>>> ---
>>> src/node_info.rs | 4 ++--
>>> 1 file changed, 2 insertions(+), 2 deletions(-)
>>>
>>> diff --git a/src/node_info.rs b/src/node_info.rs
>>> index 0f8fcb5..ca656d0 100644
>>> --- a/src/node_info.rs
>>> +++ b/src/node_info.rs
>>> @@ -204,8 +204,8 @@ pub fn node_info(data: Option<NodeStatus>) -> Container {
>>> .status(format!(
>>> "{:.2}% ({} of {})",
>>> fraction * 100.0,
>>> - HumanByte::new_decimal(root_used as f64),
>>> - HumanByte::new_decimal(root_total as f64),
>>> + HumanByte::from(root_used),
>>> + HumanByte::from(root_total),
>>> ))
>>> })
>>> .with_child({
prev parent reply other threads:[~2026-03-10 9:28 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-12-19 17:20 Shan Shaji
2026-03-09 21:22 ` Thomas Lamprecht
2026-03-10 9:02 ` Shan Shaji
2026-03-10 9:27 ` Shan Shaji [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=DGYZUIACGX8W.3GLREQLM8FB0K@proxmox.com \
--to=s.shaji@proxmox.com \
--cc=t.lamprecht@proxmox.com \
--cc=yew-devel@lists.proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox