From: "Lukas Wagner" <l.wagner@proxmox.com>
To: "Yew framework devel list at Proxmox"
<yew-devel@lists.proxmox.com>,
"Shannon Sterz" <s.sterz@proxmox.com>
Subject: Re: [yew-devel] [PATCH yew-comp 0/2] make http wasm client get fresh csrf tokens from index document
Date: Fri, 19 Dec 2025 14:14:48 +0100 [thread overview]
Message-ID: <DF27YDKJX1CM.2VSYATVTXUTIO@proxmox.com> (raw)
In-Reply-To: <20251217142613.277559-2-s.sterz@proxmox.com>
On Wed Dec 17, 2025 at 3:26 PM CET, Shannon Sterz wrote:
> this series makes the http wasm client respect the fresher csrf token
> in the document index. fixing a bug that would kick out users after
> the first non-GET request. for a more detailed explanation see patch
I definitely ran into this bug a couple of times (and always was quite
confused about why it happened), thanks for investigating and fixing
this!
> 1.
>
> changes since v1:
>
> * split csrf token portion of extract_auth_from_cookie into a separate
> function and add better documentation (thanks @ Thomas Lamprecht)
> * add a patch that refactors extract_auth_from_cookie to return a
> ticket and be more efficient and legible.
>
> Shannon Sterz (2):
> http wasm client: load csrf token from global Proxmox object
> http wasm client: refactor extract_auth_from_cookie to return a Ticket
>
> src/http_client_wasm.rs | 54 ++++++++++++++++++++++++++---------------
> 1 file changed, 35 insertions(+), 19 deletions(-)
>
Looks good from what I can tell (not at all familiar with this code
section though). Also did some general smoke testing, general auth and
POSTs work as they should.
Reviewed-by: Lukas Wagner <l.wagner@proxmox.com>
Tested-by: Lukas Wagner <l.wagner@proxmox.com>
_______________________________________________
yew-devel mailing list
yew-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/yew-devel
prev parent reply other threads:[~2025-12-19 13:14 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-12-17 14:26 Shannon Sterz
2025-12-17 14:26 ` [yew-devel] [PATCH yew-comp 1/2] http wasm client: load csrf token from global Proxmox object Shannon Sterz
2025-12-17 14:26 ` [yew-devel] [PATCH yew-comp 2/2] http wasm client: refactor extract_auth_from_cookie to return a Ticket Shannon Sterz
2025-12-19 13:14 ` Lukas Wagner [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=DF27YDKJX1CM.2VSYATVTXUTIO@proxmox.com \
--to=l.wagner@proxmox.com \
--cc=s.sterz@proxmox.com \
--cc=yew-devel@lists.proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox