From: "Lukas Wagner" <l.wagner@proxmox.com>
To: "Yew framework devel list at Proxmox"
<yew-devel@lists.proxmox.com>,
"Shannon Sterz" <s.sterz@proxmox.com>
Subject: Re: [yew-devel] [PATCH yew-comp] node info: fix displaying boot mode
Date: Wed, 03 Dec 2025 11:40:31 +0100 [thread overview]
Message-ID: <DEOINJ6HDH3E.1MLZL5DVW57VO@proxmox.com> (raw)
In-Reply-To: <20251203103745.193426-1-s.sterz@proxmox.com>
On Wed Dec 3, 2025 at 11:37 AM CET, Shannon Sterz wrote:
> BootMode::Efi and BootMode::LegacyBios were accidentally switched
> around.
>
> Signed-off-by: Shannon Sterz <s.sterz@proxmox.com>
> ---
> src/node_info.rs | 6 +++---
> 1 file changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/src/node_info.rs b/src/node_info.rs
> index b7c0360..0f8fcb5 100644
> --- a/src/node_info.rs
> +++ b/src/node_info.rs
> @@ -253,9 +253,9 @@ pub fn node_info(data: Option<NodeStatus>) -> Container {
> )
> .with_optional_child(boot_mode.map(|m| {
> let mode = match m.mode {
> - BootMode::Efi => tr!("Legacy BIOS"),
> - BootMode::LegacyBios if m.secureboot => tr!("UEFI (Secure Boot Enabled)"),
> - BootMode::LegacyBios => tr!("UEFI"),
> + BootMode::LegacyBios => tr!("Legacy BIOS"),
> + BootMode::Efi if m.secureboot => tr!("UEFI (Secure Boot Enabled)"),
> + BootMode::Efi => tr!("UEFI"),
> };
> StatusRow::new(tr!("Boot Mode"))
> .style("grid-column", "1/-1")
Thanks for the quick fix, looks good to me!
Reviewed-by: Lukas Wagner <l.wagner@proxmox.com>
_______________________________________________
yew-devel mailing list
yew-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/yew-devel
next prev parent reply other threads:[~2025-12-03 10:40 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-12-03 10:37 Shannon Sterz
2025-12-03 10:40 ` Lukas Wagner [this message]
2025-12-03 12:51 ` Thomas Lamprecht
2025-12-04 9:23 Shannon Sterz
2025-12-04 9:24 ` Shannon Sterz
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=DEOINJ6HDH3E.1MLZL5DVW57VO@proxmox.com \
--to=l.wagner@proxmox.com \
--cc=s.sterz@proxmox.com \
--cc=yew-devel@lists.proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox