Re: [yew-devel] [PATCH yew-widget-toolkit 1/2] dom: add convenience functions to get often used elements

From: Dietmar Maurer <dietmar@proxmox.com>
To: Yew framework devel list at Proxmox <yew-devel@lists.proxmox.com>,
	Dominik Csapak <d.csapak@proxmox.com>
Subject: Re: [yew-devel] [PATCH yew-widget-toolkit 1/2] dom: add convenience functions to get often used elements
Date: Mon, 5 May 2025 10:13:44 +0200 (CEST)	[thread overview]
Message-ID: <675478941.9677.1746432824405@webmail.proxmox.com> (raw)
In-Reply-To: <20250502124951.3886328-1-d.csapak@proxmox.com>

We can use gloo_utils instead?

> On 2.5.2025 14:49 CEST Dominik Csapak <d.csapak@proxmox.com> wrote:
> 
>  
> Namely window/document/body. We use them throughout our codebase with
> inline unwraps, instead we can use these helpers instead.
> 
> Signed-off-by: Dominik Csapak <d.csapak@proxmox.com>
> ---
>  src/dom/mod.rs | 20 +++++++++++++++++++-
>  1 file changed, 19 insertions(+), 1 deletion(-)
> 
> diff --git a/src/dom/mod.rs b/src/dom/mod.rs
> index f61dd21..679fab7 100644
> --- a/src/dom/mod.rs
> +++ b/src/dom/mod.rs
> @@ -13,7 +13,7 @@ pub use dom_size_observer::{DomSizeObserver, IntoSizeCallback, SizeCallback};
>  mod dom_visibility_observer;
>  pub use dom_visibility_observer::DomVisibilityObserver;
>  
> -use web_sys::Node;
> +use web_sys::{window, Document, HtmlElement, Node, Window};
>  use yew::prelude::*;
>  
>  /// A Trait to convert structs into HtmlElement when possible
> @@ -77,3 +77,21 @@ pub fn get_system_prefer_dark_mode() -> bool {
>          false
>      }
>  }
> +
> +/// Convenience function to get the [`Window`] object.
> +/// Panics if not in a browser context
> +pub fn get_window() -> Window {
> +    window().unwrap()
> +}
> +
> +/// Convenience function to get the [`Document`] object.
> +/// Panics if not in a browser context
> +pub fn get_document() -> Document {
> +    get_window().document().unwrap()
> +}
> +
> +/// Convenience function to get the a reference to the <body> tag as [`HtmlElement`].
> +/// Panics if not in a browser context
> +pub fn get_body() -> HtmlElement {
> +    get_document().body().unwrap()
> +}
> -- 
> 2.39.5
> 
> 
> 
> _______________________________________________
> yew-devel mailing list
> yew-devel@lists.proxmox.com
> https://lists.proxmox.com/cgi-bin/mailman/listinfo/yew-devel

_______________________________________________
yew-devel mailing list
yew-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/yew-devel