public inbox for yew-devel@lists.proxmox.com
 help / color / mirror / Atom feed
From: Dominik Csapak <d.csapak@proxmox.com>
To: Shannon Sterz <s.sterz@proxmox.com>,
	Yew framework devel list at Proxmox <yew-devel@lists.proxmox.com>
Subject: Re: [yew-devel] [PATCH yew-widget-toolkit-assets 5/6] application bar: reverse back arrow for rtl
Date: Fri, 27 Jun 2025 15:38:26 +0200	[thread overview]
Message-ID: <659fcb2f-1472-41c5-b866-478874d3471e@proxmox.com> (raw)
In-Reply-To: <DAXBXBNPKFB0.F40P59TII5CW@proxmox.com>

On 6/27/25 14:54, Shannon Sterz wrote:
> On Fri Jun 27, 2025 at 2:08 PM CEST, Dominik Csapak wrote:
>> so it's in the correct orientation in RTL mode.
>>
>> needs the corresponding pwt patch to set the class.
>>
>> Signed-off-by: Dominik Csapak <d.csapak@proxmox.com>
>> ---
>>   scss/_application_bar.scss | 7 +++++++
>>   1 file changed, 7 insertions(+)
>>
>> diff --git a/scss/_application_bar.scss b/scss/_application_bar.scss
>> index b367a0b..17d4e63 100644
>> --- a/scss/_application_bar.scss
>> +++ b/scss/_application_bar.scss
>> @@ -10,4 +10,11 @@
>>           padding: var(--pwt-spacer-1);
>>           gap: var(--pwt-spacer-2);
>>       }
>> +
>> +}
>> +
>> +/* change arrow icon direction */
>> +/* Note: :dir(rtl) only works with firefox, so we cant use that. */
> 
> this is not true (anymore?), `:dir()` has been declared baseline as of
> 2023 and is available in chrome since chrome 120 according to can i use
> [1,2].
> 
>> +html[dir="rtl"] .pwt-application-bar-back {
>> +  transform: scaleX(-1);
>>   }
> 
> [1]: https://developer.mozilla.org/en-US/docs/Web/CSS/:dir
> [2]: https://caniuse.com/css-dir-pseudo

yeah, true. i just copied the comment from other places, that probably were
introduced before this happened, thanks for noticing !

I'll see where else we can replace that with the ':dir()' selector


_______________________________________________
yew-devel mailing list
yew-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/yew-devel


  reply	other threads:[~2025-06-27 13:37 UTC|newest]

Thread overview: 25+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-06-27 12:08 [yew-devel] [PATCH yew-widget-toolkit/yew-widget-toolkit-assets 00/17] various touch improvements Dominik Csapak
2025-06-27 12:08 ` [yew-devel] [PATCH yew-widget-toolkit-assets 1/6] reset: remove the tap highlight color for chrome Dominik Csapak
2025-06-27 12:08 ` [yew-devel] [PATCH yew-widget-toolkit-assets 2/6] page: add more page animation styles Dominik Csapak
2025-06-27 12:08 ` [yew-devel] [PATCH yew-widget-toolkit-assets 3/6] page: animations: reverse the direction on X axis for RTL mode Dominik Csapak
2025-06-27 12:08 ` [yew-devel] [PATCH yew-widget-toolkit-assets 4/6] application bar: reduce horizontal padding Dominik Csapak
2025-06-27 12:08 ` [yew-devel] [PATCH yew-widget-toolkit-assets 5/6] application bar: reverse back arrow for rtl Dominik Csapak
2025-06-27 12:54   ` Shannon Sterz
2025-06-27 13:38     ` Dominik Csapak [this message]
2025-06-27 12:08 ` [yew-devel] [PATCH yew-widget-toolkit-assets 6/6] buttons: rework fab menu Dominik Csapak
2025-06-27 12:08 ` [yew-devel] [PATCH yew-widget-toolkit 01/11] widget: implement Image widget Dominik Csapak
2025-06-27 12:08 ` [yew-devel] [PATCH yew-widget-toolkit 02/11] widget: button: don't hardcode icons font size Dominik Csapak
2025-06-27 12:08 ` [yew-devel] [PATCH yew-widget-toolkit 03/11] touch: page stack: add more animations Dominik Csapak
2025-06-27 12:08 ` [yew-devel] [PATCH yew-widget-toolkit 04/11] touch: application bar: set custom class on back button Dominik Csapak
2025-06-27 12:08 ` [yew-devel] [PATCH yew-widget-toolkit 05/11] touch: material app: allow pass through of page animation style Dominik Csapak
2025-06-27 13:37   ` Shannon Sterz
2025-06-27 13:38     ` Dominik Csapak
2025-06-27 14:32     ` Dietmar Maurer
2025-06-27 14:40       ` Shannon Sterz
2025-06-27 12:08 ` [yew-devel] [PATCH yew-widget-toolkit 06/11] touch: scaffold: fix overflow setting for body Dominik Csapak
2025-06-27 12:08 ` [yew-devel] [PATCH yew-widget-toolkit 07/11] touch: scaffold: use direction independent positioning for the FAB Dominik Csapak
2025-06-27 12:08 ` [yew-devel] [PATCH yew-widget-toolkit 08/11] touch: fab: add size option Dominik Csapak
2025-06-27 12:08 ` [yew-devel] [PATCH yew-widget-toolkit 09/11] touch: fab: convert to widget macro Dominik Csapak
2025-06-27 12:08 ` [yew-devel] [PATCH yew-widget-toolkit 10/11] touch: fab menu: " Dominik Csapak
2025-06-27 12:08 ` [yew-devel] [PATCH yew-widget-toolkit 11/11] touch: fab menu: rework fab menu Dominik Csapak
2025-06-30  8:25 ` [yew-devel] [PATCH yew-widget-toolkit/yew-widget-toolkit-assets 00/17] various touch improvements Dominik Csapak

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=659fcb2f-1472-41c5-b866-478874d3471e@proxmox.com \
    --to=d.csapak@proxmox.com \
    --cc=s.sterz@proxmox.com \
    --cc=yew-devel@lists.proxmox.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Service provided by Proxmox Server Solutions GmbH | Privacy | Legal