public inbox for yew-devel@lists.proxmox.com
 help / color / mirror / Atom feed
From: Thomas Lamprecht <t.lamprecht@proxmox.com>
To: Yew framework devel list at Proxmox <yew-devel@lists.proxmox.com>,
	Maximiliano Sandoval <m.sandoval@proxmox.com>
Subject: Re: [yew-devel] [PATCH proxmox-yew-comp] apt_repositories: Add context to string with plural form
Date: Wed, 22 Jan 2025 18:25:25 +0100	[thread overview]
Message-ID: <586d53e7-6f69-410f-b854-ad5331fc634b@proxmox.com> (raw)
In-Reply-To: <20250122120935.231967-1-m.sandoval@proxmox.com>

Am 22.01.25 um 13:09 schrieb Maximiliano Sandoval:
> The "Warning" msgid is already used in proxmox-widget-toolkit. Gettext
> does not allow duplicated msgids and therefore they cannot be shared for
> translations with and without plurals.

Hmm, a bit odd IMO, do you have by chance any reference to some background
and/or rational here?

Can you also describe what context does in the commit message here, as this
is the first commit introducing that usage IIRC.

> 
> Signed-off-by: Maximiliano Sandoval <m.sandoval@proxmox.com>
> ---
>  src/apt_repositories.rs | 3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)
> 
> diff --git a/src/apt_repositories.rs b/src/apt_repositories.rs
> index b671d01e..487ca7f 100644
> --- a/src/apt_repositories.rs
> +++ b/src/apt_repositories.rs
> @@ -873,7 +873,8 @@ fn render_text_with_warnings(text: &str, warnings: &[String]) -> Html {
>                  <i class="fa fa-fw fa-exclamation-circle"/>
>              </span>
>          };
> -        let title = tr!("Warning" | "Warnings" % warnings.len());
> +        let title =
> +            tr!("This is a title" => "Warning" | "Warnings" % warnings.len());

Do I need to use this context every time I use just the plural variant?
And if that's the case, would another context make more sense, like
"Unconditional plural"? Just trying to get a better understanding of the
details here.


_______________________________________________
yew-devel mailing list
yew-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/yew-devel


  reply	other threads:[~2025-01-22 17:26 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-01-22 12:09 Maximiliano Sandoval
2025-01-22 17:25 ` Thomas Lamprecht [this message]
2025-01-23  9:57   ` Maximiliano Sandoval

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=586d53e7-6f69-410f-b854-ad5331fc634b@proxmox.com \
    --to=t.lamprecht@proxmox.com \
    --cc=m.sandoval@proxmox.com \
    --cc=yew-devel@lists.proxmox.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Service provided by Proxmox Server Solutions GmbH | Privacy | Legal