Re: [PATCH yew-widget-toolkit v3] widget: add 'div', 'span' and 'italic' helper functions

[Dominik Csapak <d.csapak@proxmox.com>]

On 4/8/26 10:57 AM, Robert Obkircher wrote:
> 
> On 08.04.26 09:55, Shannon Sterz wrote:
>> On Wed Apr 8, 2026 at 9:12 AM CEST, Dominik Csapak wrote:
>>>
>>> On 4/7/26 7:25 PM, Dietmar Maurer wrote:
>>>> italic() is IMHO very missleading ...
>>> On 4/7/26 5:04 PM, Shannon Sterz wrote:
>>>> On Tue Apr 7, 2026 at 3:13 PM CEST, Dominik Csapak wrote:
>>>>> ah, missed inserting the changelog, so here it is:
>>>>>
>>>>> changes from v2:
>>>>> * use standalone functions instead of macro
>>>>> * add span/italic too for convenience
>>>>> * make container mod public
>>>> one small thing that occured to me is that the `<i>` element no longer
>>>> is inteded for "italic text", but rather is a semantic element that
>>>> should be used for "text that is set off from the normal prose for
>>>> readability reasons" [1].
>>>>
>>>> so it might be more appropriate to use a `span` with italic styling here
>>>> or we could add helpers for other semantic text elements such as `<em>`
>>>> etc. too. no hard feelings on my side, though, i don't think this
>>>> matters all too much.
>>>>
>>>> [1]: https://developer.mozilla.org/en-US/docs/Web/HTML/Reference/Elements/i#usage_notes
>>>>
>>>> but overall, looks good to me, so consider this:
>>>>
>>>
>>> i actually didn't want to express the italic styling here, but wanted
>>> to have the 'i' tag (since we use that often for icons and so on),
>>> but didn't come up with a better name than 'italic'. I also didn't want
>>> to add a single-letter function.
>>>
>>> does any of you have a better idea ?
>>>
>>> mdn calls it the "Idiomatic Text element" but 'idiomatic()' also does
>>> not really convey what it does.
>>>
>>> I can of course leave it out for now and we can decide later.
>> just to put a couple of ideas out there: keeping with the rest of the
>> functions here would be `i()`, but that might be a bit too short.
>>
>> we could maybe have a naming convention for wrapper helpers like this
>> like `i_element()`, `span_element()`, and `div_element()` (alternatively
>> replace `element` with `container` or `wrapper`). that feels a bit
>> unnecessarily verbose, though.
> Or a module like `tag::i` to let the caller decide whether the
> function should be imported directly.
>> if the intention is for this to mostly be used with icons, maybe that is
>> best handled separately? for example, with an `Icon` component that
>> takes the appropriate icon classes. somewhat analogous to `ActionIcon`
>> except without the interactive component.
>>
>> --> snip <--
>>
>>
>>
>>

I think I'll simply leave the i tag out for now. It's not necessary,
and we could use our 'Fa' for most of the icons.

i'll send a v4