[PATCH yew-widget-toolkit] fix #8057: correctly scroll on firefox with submenus

[PATCH yew-widget-toolkit] fix #8057: correctly scroll on firefox with submenus

[Dominik Csapak]

There is a subtle difference in calculating the height of nested
grid containers: chrome uses the min-content height while firefox does
not. This means, on firefox, the navigation drawer would not have it's
intended size + scrollbars, but would clip the submenus since they would
shrink.

Fix this by giving the whole menu a container that can grow, and only
scroll the outer container.

This fixes an issue on PDM, where a bigger number of remotes would not
allow the users to scroll, but clip the list.

Fixes: f5bfd42 (widget: navigation drawer: make menu collapsing/expanding animated)
Signed-off-by: Dominik Csapak <d.csapak@proxmox.com>
---
 src/widget/nav/navigation_drawer.rs | 8 ++++++--
 1 file changed, 6 insertions(+), 2 deletions(-)

diff --git a/src/widget/nav/navigation_drawer.rs b/src/widget/nav/navigation_drawer.rs
index 87f0743..8b99cc9 100644
--- a/src/widget/nav/navigation_drawer.rs
+++ b/src/widget/nav/navigation_drawer.rs
@@ -632,7 +632,7 @@ impl Component for PwtNavigationDrawer {
             event.prevent_default();
         });
 
-        let mut column = Column::new()
+        let menu = Column::new()
             .onkeydown(onkeydown)
             // avoid https://bugzilla.mozilla.org/show_bug.cgi?id=1069739
             .attribute("tabindex", "-1")
@@ -649,11 +649,15 @@ impl Component for PwtNavigationDrawer {
         let active = get_active_or_default(props, &self.active);
         let active = active.as_deref().unwrap_or("");
 
+        // inner container that can take the full height of the children,
+        // so the outer one can scroll
+        let mut column = Column::new();
         for item in props.menu.children.iter() {
             self.render_menu_entry(ctx, item, &mut column, active, 0, false);
         }
 
-        column.into_html_with_ref(self.node_ref.clone())
+        menu.with_child(column)
+            .into_html_with_ref(self.node_ref.clone())
     }
 }
 
-- 
2.47.3