[PATCH yew-widget-toolkit 4/4] dom: align: fix fallback check for placements

[Dominik Csapak <d.csapak@proxmox.com>]

'try_fit_rect' takes a 'has_fallback' parameter, and it was intended
that this is false only for the last placement in the list.

Since `skip(1)` was done before `enumerate()`, the index was off by one.
Also the index is always smaller than `len()` so we have to compensate
by 1 for that.

Fix this by changing the order of `enumerate` and `skip` so the index is
the 'correct' one, and add +1 before checking against the length.

While at it, reuse `num_placements` instead of calculating the length
again.

Signed-off-by: Dominik Csapak <d.csapak@proxmox.com>
---
 src/dom/align.rs | 7 +++----
 1 file changed, 3 insertions(+), 4 deletions(-)

diff --git a/src/dom/align.rs b/src/dom/align.rs
index a20cc6e..7d7fea8 100644
--- a/src/dom/align.rs
+++ b/src/dom/align.rs
@@ -480,16 +480,15 @@ where
     );
 
     // try fallback placements if the first one does not fit
-    if options.placements.len() > 1 && !fits(&rect, &window_rect, &options.placements[0].direction)
-    {
-        for (idx, placement) in options.placements.iter().skip(1).enumerate() {
+    if num_placements > 1 && !fits(&rect, &window_rect, &options.placements[0].direction) {
+        for (idx, placement) in options.placements.iter().enumerate().skip(1) {
             let new_rect = try_fit_rect(
                 &base,
                 &element,
                 &window_rect,
                 placement,
                 options.offset,
-                idx < num_placements,
+                idx + 1 < num_placements,
             );
 
             if fits(&new_rect, &window_rect, &placement.direction) {
-- 
2.47.3