public inbox for yew-devel@lists.proxmox.com
 help / color / mirror / Atom feed
From: Dominik Csapak <d.csapak@proxmox.com>
To: yew-devel@lists.proxmox.com
Subject: [PATCH yew-widget-toolkit 3/4] widget: form: radio button: use 'radio' aria role instead of 'checkbox'
Date: Fri, 17 Jul 2026 14:55:30 +0200	[thread overview]
Message-ID: <20260717125555.2898147-4-d.csapak@proxmox.com> (raw)
In-Reply-To: <20260717125555.2898147-1-d.csapak@proxmox.com>

According to MDN[0], this is the correct aria role for a radio button.

0: https://developer.mozilla.org/en-US/docs/Web/Accessibility/ARIA/Reference/Roles/radio_role

Signed-off-by: Dominik Csapak <d.csapak@proxmox.com>
---
 src/widget/form/radio_button.rs | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/src/widget/form/radio_button.rs b/src/widget/form/radio_button.rs
index 3620add..ab3ffb8 100644
--- a/src/widget/form/radio_button.rs
+++ b/src/widget/form/radio_button.rs
@@ -276,7 +276,7 @@ impl ManagedField for RadioButtonField {
                     "tabindex",
                     props.input_props.tabindex.unwrap_or(0).to_string(),
                 )
-                .attribute("role", "checkbox")
+                .attribute("role", "radio")
                 .attribute("aria-checked", checked.then_some("true"))
                 .onkeyup(onkeyup)
                 .into_html_with_ref(self.node_ref.clone()),
-- 
2.47.3





  parent reply	other threads:[~2026-07-17 12:55 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-07-17 12:55 [PATCH yew-widget-toolkit 0/4] small cleanups/fixes Dominik Csapak
2026-07-17 12:55 ` [PATCH yew-widget-toolkit 1/4] widget: form: radio button: fix property comments Dominik Csapak
2026-07-17 12:55 ` [PATCH yew-widget-toolkit 2/4] widget: form: radio button: dim boxlabel when disabled Dominik Csapak
2026-07-17 12:55 ` Dominik Csapak [this message]
2026-07-17 12:55 ` [PATCH yew-widget-toolkit 4/4] dom: align: fix fallback check for placements Dominik Csapak
2026-07-17 21:59 ` applied: [PATCH yew-widget-toolkit 0/4] small cleanups/fixes Thomas Lamprecht

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20260717125555.2898147-4-d.csapak@proxmox.com \
    --to=d.csapak@proxmox.com \
    --cc=yew-devel@lists.proxmox.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Service provided by Proxmox Server Solutions GmbH | Privacy | Legal