public inbox for yew-devel@lists.proxmox.com
 help / color / mirror / Atom feed
From: Shannon Sterz <s.sterz@proxmox.com>
To: yew-devel@lists.proxmox.com
Subject: [PATCH yew-comp] auth view: don't mark realm sync dialog as "edit" and set submit text
Date: Wed, 25 Mar 2026 12:43:35 +0100	[thread overview]
Message-ID: <20260325114334.137252-2-s.sterz@proxmox.com> (raw)

previously it was not possible to submit this window without making
any changes since setting a loader marked the window as being in "edit
mode". leading to the paradoxical scenario where running a sync job
with the default settings for that realm wasn't possible.

change this behaviour by marking the `EditWindow` as not being in
"edit mode" and setting a more appropriate text for the submit button.
the side-effect of this is that the reset button is no longer
available, but that is deemed preferable over not being able to sync
with a realm's default configuration.

Signed-off-by: Shannon Sterz <s.sterz@proxmox.com>
---

Notes:
    it might be preferable to split up behaviour here. maybe whether the
    reset button is rendered and "check_dirty" is enabled on the submit
    button should be separate settings. but that would have had wider
    implications across our ecosystem, so i opted for this smaller set of
    changes here.

 src/auth_view.rs | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/src/auth_view.rs b/src/auth_view.rs
index 7a88f4c..9a06979 100644
--- a/src/auth_view.rs
+++ b/src/auth_view.rs
@@ -469,6 +469,8 @@ impl LoadableComponent for ProxmoxAuthView {
                                 format!("{base_url}/{}", percent_encode_component(&realm.realm));
                             move || load_realm(url.clone())
                         })
+                        .edit(false)
+                        .submit_text(tr!("Start Sync"))
                         .submit_digest(false)
                         .on_close(link.change_view_callback(|_| None))
                         .on_submit(move |form_context| {
-- 
2.47.3





                 reply	other threads:[~2026-03-25 11:44 UTC|newest]

Thread overview: [no followups] expand[flat|nested]  mbox.gz  Atom feed

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20260325114334.137252-2-s.sterz@proxmox.com \
    --to=s.sterz@proxmox.com \
    --cc=yew-devel@lists.proxmox.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Service provided by Proxmox Server Solutions GmbH | Privacy | Legal