public inbox for yew-devel@lists.proxmox.com
 help / color / mirror / Atom feed
From: Shannon Sterz <s.sterz@proxmox.com>
To: yew-devel@lists.proxmox.com
Subject: [PATCH yew-comp 06/15] tree wide: fix clippy lint "clone_on_copy"
Date: Fri,  6 Mar 2026 12:21:38 +0100	[thread overview]
Message-ID: <20260306112148.208189-7-s.sterz@proxmox.com> (raw)
In-Reply-To: <20260306112148.208189-1-s.sterz@proxmox.com>

see:
https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy
Signed-off-by: Shannon Sterz <s.sterz@proxmox.com>
---
 src/form/pve/lxc_property/lxc_mount_point_property.rs | 2 +-
 src/form/pve/pve_guest_selector.rs                    | 4 ++--
 src/form/pve/pve_storage_content_selector.rs          | 6 +++---
 src/form/pve/qemu_disk_format_selector.rs             | 2 +-
 4 files changed, 7 insertions(+), 7 deletions(-)

diff --git a/src/form/pve/lxc_property/lxc_mount_point_property.rs b/src/form/pve/lxc_property/lxc_mount_point_property.rs
index c0dd36f..379577d 100644
--- a/src/form/pve/lxc_property/lxc_mount_point_property.rs
+++ b/src/form/pve/lxc_property/lxc_mount_point_property.rs
@@ -416,7 +416,7 @@ fn mount_point_property(
             move |mut record: Value| {
                 let used_mount_points = extract_used_mount_points(&record);
                 let default_mount_point = first_unused_mount_point(&used_mount_points);
-                record[MOUNT_POINT_ID] = default_mount_point.clone().into();
+                record[MOUNT_POINT_ID] = default_mount_point.into();
 
                 if unused_disk.is_none() {
                     if let Some(name) = &name {
diff --git a/src/form/pve/pve_guest_selector.rs b/src/form/pve/pve_guest_selector.rs
index f4ff7ab..e1fcf2d 100644
--- a/src/form/pve/pve_guest_selector.rs
+++ b/src/form/pve/pve_guest_selector.rs
@@ -141,8 +141,8 @@ impl PveGuestSelectorComp {
         let props = ctx.props();
         let remote = props.remote.clone();
         let guest_type = props.guest_type;
-        let templates = props.templates.clone();
-        let exclude_guest = props.exclude_guest.clone();
+        let templates = props.templates;
+        let exclude_guest = props.exclude_guest;
         (move || Self::get_guest_list(remote.clone(), guest_type, exclude_guest, templates)).into()
     }
 }
diff --git a/src/form/pve/pve_storage_content_selector.rs b/src/form/pve/pve_storage_content_selector.rs
index fdb3d96..9151851 100644
--- a/src/form/pve/pve_storage_content_selector.rs
+++ b/src/form/pve/pve_storage_content_selector.rs
@@ -126,15 +126,15 @@ impl PveStorageContentSelectorComp {
         let props = ctx.props();
         let node = props.node.clone();
         let storage = props.storage.clone();
-        let content_filter = props.content_filter.clone();
+        let content_filter = props.content_filter;
         let vmid_filter = props.vmid_filter;
 
         (move || {
             Self::get_storage_content(
                 node.clone().unwrap_or("localhost".into()),
                 storage.clone(),
-                content_filter.clone(),
-                vmid_filter.clone(),
+                content_filter,
+                vmid_filter,
             )
         })
         .into()
diff --git a/src/form/pve/qemu_disk_format_selector.rs b/src/form/pve/qemu_disk_format_selector.rs
index 5b26d2f..99d3642 100644
--- a/src/form/pve/qemu_disk_format_selector.rs
+++ b/src/form/pve/qemu_disk_format_selector.rs
@@ -147,7 +147,7 @@ impl Component for QemuDiskFormatComp {
                     .read()
                     .iter()
                     .find(|item| *item.format_text == *key)
-                    .map(|entry| entry.format.clone());
+                    .map(|entry| entry.format);
 
                 if let Some(on_change) = &on_change {
                     on_change.emit(format);
-- 
2.47.3





  parent reply	other threads:[~2026-03-06 11:21 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-03-06 11:21 [PATCH yew-comp 00/15] clippy clean up proxmox-yew-comp Shannon Sterz
2026-03-06 11:21 ` [PATCH yew-comp 01/15] tree wide: fix clippy lint "useless_conversion" Shannon Sterz
2026-03-06 11:21 ` [PATCH yew-comp 02/15] tree wide: fix clippy lint "new_without_default" Shannon Sterz
2026-03-06 11:21 ` [PATCH yew-comp 03/15] tree wide: fix clippy lint "redundant_static_lifetimes" Shannon Sterz
2026-03-06 11:21 ` [PATCH yew-comp 04/15] tree wide: fix clippy lint "unnecessary_lazy_evaluations" Shannon Sterz
2026-03-06 11:21 ` [PATCH yew-comp 05/15] tree wide: fix clippy lint "unwrap_or_default" Shannon Sterz
2026-03-06 11:21 ` Shannon Sterz [this message]
2026-03-06 11:21 ` [PATCH yew-comp 07/15] tree wide: fix clippy lint "collapsible_else_if" Shannon Sterz
2026-03-06 11:21 ` [PATCH yew-comp 08/15] tree wide: fix various minor clippy lints Shannon Sterz
2026-03-06 11:21 ` [PATCH yew-comp 09/15] tree wide: fix clippy lint "manual_strip" Shannon Sterz
2026-03-06 11:21 ` [PATCH yew-comp 10/15] lxc_property/qemu_property: fix clippy lint "match_like_matches_macro" Shannon Sterz
2026-03-06 11:21 ` [PATCH yew-comp 11/15] firewall_property: fix clippy lint "redundant_guards" Shannon Sterz
2026-03-06 11:21 ` [PATCH yew-comp 12/15] qemu_property: fix clippy lint "redundant_pattern_matching" Shannon Sterz
2026-03-06 11:21 ` [PATCH yew-comp 13/15] qemu_hardware_pane/lxc_resources_panel: allow clippy::enum_variant_names Shannon Sterz
2026-03-06 11:21 ` [PATCH yew-comp 14/15] tree wide: fix clippy lint "large_enum_variant" Shannon Sterz
2026-03-06 11:21 ` [PATCH yew-comp 15/15] tree wide: allow clippy "too_many_arguments" warning selectively Shannon Sterz

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20260306112148.208189-7-s.sterz@proxmox.com \
    --to=s.sterz@proxmox.com \
    --cc=yew-devel@lists.proxmox.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Service provided by Proxmox Server Solutions GmbH | Privacy | Legal