[yew-devel] [PATCH proxmox-yew-comp 1/2] add translation comments to translatable strings

[yew-devel] [PATCH proxmox-yew-comp 1/2] add translation comments to translatable strings

[Maximiliano Sandoval]

Signed-off-by: Maximiliano Sandoval <m.sandoval@proxmox.com>
---
 src/auth_view.rs | 1 +
 src/utils/mod.rs | 1 +
 2 files changed, 2 insertions(+)

diff --git a/src/auth_view.rs b/src/auth_view.rs
index 82f6041..8a86bc2 100644
--- a/src/auth_view.rs
+++ b/src/auth_view.rs
@@ -312,6 +312,7 @@ impl LoadableComponent for ProxmoxAuthView {
 
         if props.openid_base_url.is_some() {
             add_menu.add_item(
+                // TRANSLATORS: "OpenID Connect" is a proper name
                 MenuItem::new(tr!("OpenId Connect Server"))
                     .icon_class("fa fa-fw fa-openid")
                     .on_select(
diff --git a/src/utils/mod.rs b/src/utils/mod.rs
index 8804b6b..856297f 100644
--- a/src/utils/mod.rs
+++ b/src/utils/mod.rs
@@ -238,6 +238,7 @@ pub fn registered_task_types() -> Vec<String> {
 
 pub fn init_task_descr_table_base() {
     register_task_description("aptupdate", tr!("Update package database"));
+    // TRANSLATORS: Spice is a proper name, see https://www.spice-space.org
     register_task_description("spiceshell", tr!("Shell (Spice)"));
     register_task_description("vncshell", tr!("Shell (VNC)"));
     register_task_description("termproxy", tr!("Console (xterm.js)"));
-- 
2.47.3



_______________________________________________
yew-devel mailing list
yew-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/yew-devel

[yew-devel] [PATCH proxmox-yew-comp 2/2] mark strings as translatable

[Maximiliano Sandoval]

Signed-off-by: Maximiliano Sandoval <m.sandoval@proxmox.com>
---
 src/auth_view.rs   | 2 +-
 src/object_grid.rs | 4 ++--
 src/tasks.rs       | 2 +-
 3 files changed, 4 insertions(+), 4 deletions(-)

diff --git a/src/auth_view.rs b/src/auth_view.rs
index 8a86bc2..75deefb 100644
--- a/src/auth_view.rs
+++ b/src/auth_view.rs
@@ -326,7 +326,7 @@ impl LoadableComponent for ProxmoxAuthView {
             .class("pwt-w-100")
             .class("pwt-overflow-hidden")
             .class("pwt-border-bottom")
-            .with_child(MenuButton::new("Add").show_arrow(true).menu(add_menu))
+            .with_child(MenuButton::new(tr!("Add")).show_arrow(true).menu(add_menu))
             .with_child(
                 Button::new(tr!("Edit"))
                     .disabled(edit_disabled)
diff --git a/src/object_grid.rs b/src/object_grid.rs
index 40214a3..6381c8e 100644
--- a/src/object_grid.rs
+++ b/src/object_grid.rs
@@ -325,7 +325,7 @@ impl PwtObjectGrid {
         let editor = self.editors.get(&name)?.clone();
 
         Some(
-            EditWindow::new(format!("Edit: {}", title))
+            EditWindow::new(format!("{edit}: {title}", edit = tr!("Edit")))
                 .loader(props.loader.clone())
                 .on_done(ctx.link().change_view_callback(|_| None))
                 .renderer(move |form_state| (editor.0)(form_state, &name, &value, &data))
@@ -429,7 +429,7 @@ impl LoadableComponent for PwtObjectGrid {
 
         let mut toolbar = Toolbar::new()
             .border_bottom(true)
-            .with_child(Button::new("Edit").disabled(disable_edit).onclick({
+            .with_child(Button::new(tr!("Edit")).disabled(disable_edit).onclick({
                 let link = ctx.link().clone();
                 move |_| {
                     link.change_view(Some(ViewState::EditObject));
diff --git a/src/tasks.rs b/src/tasks.rs
index 8dec24f..ece8f2e 100644
--- a/src/tasks.rs
+++ b/src/tasks.rs
@@ -387,7 +387,7 @@ impl LoadableComponent for ProxmoxTasks {
                     .onclick(move |_| form_context.write().reset_form())
             })
             .with_child(
-                Button::new("Filter")
+                Button::new(tr!("Filter"))
                     .icon_class(filter_icon_class)
                     .onclick(ctx.link().callback(|_| Msg::ToggleFilter)),
             )
-- 
2.47.3



_______________________________________________
yew-devel mailing list
yew-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/yew-devel

[yew-devel] applied: [PATCH proxmox-yew-comp 2/2] mark strings as translatable

[Dietmar Maurer]

applied


_______________________________________________
yew-devel mailing list
yew-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/yew-devel

[yew-devel] applied: [PATCH proxmox-yew-comp 1/2] add translation comments to translatable strings

[Dietmar Maurer]

applied this one


_______________________________________________
yew-devel mailing list
yew-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/yew-devel