* [yew-devel] [PATCH yew-comp] node info: fix displaying boot mode
@ 2025-12-03 10:37 Shannon Sterz
2025-12-03 10:40 ` Lukas Wagner
2025-12-03 12:51 ` Thomas Lamprecht
0 siblings, 2 replies; 5+ messages in thread
From: Shannon Sterz @ 2025-12-03 10:37 UTC (permalink / raw)
To: yew-devel
BootMode::Efi and BootMode::LegacyBios were accidentally switched
around.
Signed-off-by: Shannon Sterz <s.sterz@proxmox.com>
---
src/node_info.rs | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/src/node_info.rs b/src/node_info.rs
index b7c0360..0f8fcb5 100644
--- a/src/node_info.rs
+++ b/src/node_info.rs
@@ -253,9 +253,9 @@ pub fn node_info(data: Option<NodeStatus>) -> Container {
)
.with_optional_child(boot_mode.map(|m| {
let mode = match m.mode {
- BootMode::Efi => tr!("Legacy BIOS"),
- BootMode::LegacyBios if m.secureboot => tr!("UEFI (Secure Boot Enabled)"),
- BootMode::LegacyBios => tr!("UEFI"),
+ BootMode::LegacyBios => tr!("Legacy BIOS"),
+ BootMode::Efi if m.secureboot => tr!("UEFI (Secure Boot Enabled)"),
+ BootMode::Efi => tr!("UEFI"),
};
StatusRow::new(tr!("Boot Mode"))
.style("grid-column", "1/-1")
--
2.47.3
_______________________________________________
yew-devel mailing list
yew-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/yew-devel
^ permalink raw reply [flat|nested] 5+ messages in thread* Re: [yew-devel] [PATCH yew-comp] node info: fix displaying boot mode
2025-12-03 10:37 [yew-devel] [PATCH yew-comp] node info: fix displaying boot mode Shannon Sterz
@ 2025-12-03 10:40 ` Lukas Wagner
2025-12-03 12:51 ` Thomas Lamprecht
1 sibling, 0 replies; 5+ messages in thread
From: Lukas Wagner @ 2025-12-03 10:40 UTC (permalink / raw)
To: Yew framework devel list at Proxmox, Shannon Sterz
On Wed Dec 3, 2025 at 11:37 AM CET, Shannon Sterz wrote:
> BootMode::Efi and BootMode::LegacyBios were accidentally switched
> around.
>
> Signed-off-by: Shannon Sterz <s.sterz@proxmox.com>
> ---
> src/node_info.rs | 6 +++---
> 1 file changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/src/node_info.rs b/src/node_info.rs
> index b7c0360..0f8fcb5 100644
> --- a/src/node_info.rs
> +++ b/src/node_info.rs
> @@ -253,9 +253,9 @@ pub fn node_info(data: Option<NodeStatus>) -> Container {
> )
> .with_optional_child(boot_mode.map(|m| {
> let mode = match m.mode {
> - BootMode::Efi => tr!("Legacy BIOS"),
> - BootMode::LegacyBios if m.secureboot => tr!("UEFI (Secure Boot Enabled)"),
> - BootMode::LegacyBios => tr!("UEFI"),
> + BootMode::LegacyBios => tr!("Legacy BIOS"),
> + BootMode::Efi if m.secureboot => tr!("UEFI (Secure Boot Enabled)"),
> + BootMode::Efi => tr!("UEFI"),
> };
> StatusRow::new(tr!("Boot Mode"))
> .style("grid-column", "1/-1")
Thanks for the quick fix, looks good to me!
Reviewed-by: Lukas Wagner <l.wagner@proxmox.com>
_______________________________________________
yew-devel mailing list
yew-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/yew-devel
^ permalink raw reply [flat|nested] 5+ messages in thread* Re: [yew-devel] [PATCH yew-comp] node info: fix displaying boot mode
2025-12-03 10:37 [yew-devel] [PATCH yew-comp] node info: fix displaying boot mode Shannon Sterz
2025-12-03 10:40 ` Lukas Wagner
@ 2025-12-03 12:51 ` Thomas Lamprecht
1 sibling, 0 replies; 5+ messages in thread
From: Thomas Lamprecht @ 2025-12-03 12:51 UTC (permalink / raw)
To: yew-devel, Shannon Sterz
On Wed, 03 Dec 2025 11:37:45 +0100, Shannon Sterz wrote:
> BootMode::Efi and BootMode::LegacyBios were accidentally switched
> around.
>
>
Applied, thanks!
[1/1] node info: fix displaying boot mode
commit: 31d8b3a6f07d36fa1368ca1ed6da8a54f8e29972
_______________________________________________
yew-devel mailing list
yew-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/yew-devel
^ permalink raw reply [flat|nested] 5+ messages in thread
* [yew-devel] [PATCH yew-comp] node info: fix displaying boot mode
@ 2025-12-04 9:23 Shannon Sterz
2025-12-04 9:24 ` Shannon Sterz
0 siblings, 1 reply; 5+ messages in thread
From: Shannon Sterz @ 2025-12-04 9:23 UTC (permalink / raw)
To: yew-devel
BootMode::Efi and BootMode::LegacyBios were accidentally switched
around.
Signed-off-by: Shannon Sterz <s.sterz@proxmox.com>
---
src/node_info.rs | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/src/node_info.rs b/src/node_info.rs
index b7c0360..0f8fcb5 100644
--- a/src/node_info.rs
+++ b/src/node_info.rs
@@ -253,9 +253,9 @@ pub fn node_info(data: Option<NodeStatus>) -> Container {
)
.with_optional_child(boot_mode.map(|m| {
let mode = match m.mode {
- BootMode::Efi => tr!("Legacy BIOS"),
- BootMode::LegacyBios if m.secureboot => tr!("UEFI (Secure Boot Enabled)"),
- BootMode::LegacyBios => tr!("UEFI"),
+ BootMode::LegacyBios => tr!("Legacy BIOS"),
+ BootMode::Efi if m.secureboot => tr!("UEFI (Secure Boot Enabled)"),
+ BootMode::Efi => tr!("UEFI"),
};
StatusRow::new(tr!("Boot Mode"))
.style("grid-column", "1/-1")
--
2.47.3
_______________________________________________
yew-devel mailing list
yew-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/yew-devel
^ permalink raw reply [flat|nested] 5+ messages in thread* Re: [yew-devel] [PATCH yew-comp] node info: fix displaying boot mode
2025-12-04 9:23 Shannon Sterz
@ 2025-12-04 9:24 ` Shannon Sterz
0 siblings, 0 replies; 5+ messages in thread
From: Shannon Sterz @ 2025-12-04 9:24 UTC (permalink / raw)
To: Shannon Sterz; +Cc: yew-devel
sorry send this by accident.
On Thu Dec 4, 2025 at 10:23 AM CET, Shannon Sterz wrote:
> BootMode::Efi and BootMode::LegacyBios were accidentally switched
> around.
>
> Signed-off-by: Shannon Sterz <s.sterz@proxmox.com>
> ---
> src/node_info.rs | 6 +++---
> 1 file changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/src/node_info.rs b/src/node_info.rs
> index b7c0360..0f8fcb5 100644
> --- a/src/node_info.rs
> +++ b/src/node_info.rs
> @@ -253,9 +253,9 @@ pub fn node_info(data: Option<NodeStatus>) -> Container {
> )
> .with_optional_child(boot_mode.map(|m| {
> let mode = match m.mode {
> - BootMode::Efi => tr!("Legacy BIOS"),
> - BootMode::LegacyBios if m.secureboot => tr!("UEFI (Secure Boot Enabled)"),
> - BootMode::LegacyBios => tr!("UEFI"),
> + BootMode::LegacyBios => tr!("Legacy BIOS"),
> + BootMode::Efi if m.secureboot => tr!("UEFI (Secure Boot Enabled)"),
> + BootMode::Efi => tr!("UEFI"),
> };
> StatusRow::new(tr!("Boot Mode"))
> .style("grid-column", "1/-1")
_______________________________________________
yew-devel mailing list
yew-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/yew-devel
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2025-12-04 9:24 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2025-12-03 10:37 [yew-devel] [PATCH yew-comp] node info: fix displaying boot mode Shannon Sterz
2025-12-03 10:40 ` Lukas Wagner
2025-12-03 12:51 ` Thomas Lamprecht
2025-12-04 9:23 Shannon Sterz
2025-12-04 9:24 ` Shannon Sterz
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox