From: Hannes Laimer <h.laimer@proxmox.com>
To: yew-devel@lists.proxmox.com
Subject: [yew-devel] [PATCH yew-comp] delete_empty_values: use array instead of string-list
Date: Wed, 29 Oct 2025 18:35:28 +0100	[thread overview]
Message-ID: <20251029173528.378487-1-h.laimer@proxmox.com> (raw)
PVE does accept arrays since [1], and with [2] PDM expects arrays.
[1] pve-common 69d9edcc ("section config: implement array support")
[2] proxmox bd8eca6b ("pve-api-types: schema2rust: generate arrays for types with format `-list`")
Signed-off-by: Hannes Laimer <h.laimer@proxmox.com>
---
This was somewhat recently changed to a string-list, but with the recent
change in the PVE type generation we need an actual array here.
 src/form/mod.rs | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/src/form/mod.rs b/src/form/mod.rs
index 6a92a90..0c23053 100644
--- a/src/form/mod.rs
+++ b/src/form/mod.rs
@@ -44,7 +44,7 @@ pub fn delete_empty_values(record: &Value, param_list: &[&str], delete_undefined
     }
 
     if !delete.is_empty() {
-        new["delete"] = delete.join(",").into();
+        new["delete"] = delete.into();
     }
 
     new
-- 
2.47.3
_______________________________________________
yew-devel mailing list
yew-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/yew-devel
                 reply	other threads:[~2025-10-29 17:35 UTC|newest]
Thread overview: [no followups] expand[flat|nested]  mbox.gz  Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox
  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):
  git send-email \
    --in-reply-to=20251029173528.378487-1-h.laimer@proxmox.com \
    --to=h.laimer@proxmox.com \
    --cc=yew-devel@lists.proxmox.com \
    /path/to/YOUR_REPLY
  https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
  Be sure your reply has a Subject: header at the top and a blank line
  before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox