public inbox for yew-devel@lists.proxmox.com
 help / color / mirror / Atom feed
From: Dominik Csapak <d.csapak@proxmox.com>
To: yew-devel@lists.proxmox.com
Subject: [yew-devel] [PATCH yew-widget-toolkit v2 11/12] touch: fab menu: convert to widget macro
Date: Mon, 30 Jun 2025 10:25:08 +0200	[thread overview]
Message-ID: <20250630082509.1202308-19-d.csapak@proxmox.com> (raw)
In-Reply-To: <20250630082509.1202308-1-d.csapak@proxmox.com>

This does many things we did here manually.

Signed-off-by: Dominik Csapak <d.csapak@proxmox.com>
---
 src/touch/fab_menu.rs | 57 ++++++-------------------------------------
 1 file changed, 8 insertions(+), 49 deletions(-)

diff --git a/src/touch/fab_menu.rs b/src/touch/fab_menu.rs
index 4ad1234..92f2331 100644
--- a/src/touch/fab_menu.rs
+++ b/src/touch/fab_menu.rs
@@ -1,12 +1,10 @@
-use std::rc::Rc;
-
-use yew::html::IntoPropValue;
 use yew::prelude::*;
-use yew::virtual_dom::{Key, VComp, VNode};
 
 use crate::props::{ContainerBuilder, EventSubscriber, WidgetBuilder};
 use crate::widget::Container;
 
+use pwt_macros::{builder, widget};
+
 use super::Fab;
 
 /// [FabMenu] direction.
@@ -27,12 +25,10 @@ pub enum FabMenuAlign {
 }
 
 /// Favorite actions button Menu.
+#[widget(pwt=crate, comp=PwtFabMenu, @element)]
 #[derive(Properties, Clone, PartialEq)]
+#[builder]
 pub struct FabMenu {
-    /// The yew component key.
-    #[prop_or_default]
-    pub key: Option<Key>,
-
     /// Main button Icon (CSS class).
     #[prop_or_default]
     pub main_icon_class: Option<Classes>,
@@ -43,11 +39,13 @@ pub struct FabMenu {
 
     /// Menu popup direction
     #[prop_or(FabMenuDirection::Up)]
+    #[builder]
     pub direction: FabMenuDirection,
 
     /// Menu alignment
     ///
     #[prop_or(FabMenuAlign::Center)]
+    #[builder]
     pub align: FabMenuAlign,
 
     /// Child buttons, which popup when main button is pressed.
@@ -69,17 +67,6 @@ impl FabMenu {
         yew::props!(Self {})
     }
 
-    /// Builder style method to set the yew `key` property
-    pub fn key(mut self, key: impl IntoPropValue<Option<Key>>) -> Self {
-        self.set_key(key);
-        self
-    }
-
-    /// Method to set the yew `key` property
-    pub fn set_key(&mut self, key: impl IntoPropValue<Option<Key>>) {
-        self.key = key.into_prop_value();
-    }
-
     /// Builder style method to set the icon class for the main button.
     pub fn main_icon_class(mut self, class: impl Into<Classes>) -> Self {
         self.set_main_icon_class(class);
@@ -106,28 +93,6 @@ impl FabMenu {
         }
     }
 
-    /// Builder style method to set the popup alignment
-    pub fn align(mut self, align: FabMenuAlign) -> Self {
-        self.set_align(align);
-        self
-    }
-
-    /// Method to set the popup alignment
-    pub fn set_align(&mut self, align: FabMenuAlign) {
-        self.align = align;
-    }
-
-    /// Builder style method to set the popup direction
-    pub fn direction(mut self, direction: FabMenuDirection) -> Self {
-        self.set_direction(direction);
-        self
-    }
-
-    /// Method to set the popup direction
-    pub fn set_direction(&mut self, direction: FabMenuDirection) {
-        self.direction = direction;
-    }
-
     /// Builder style method to add a child button
     pub fn with_child(mut self, child: impl Into<Fab>) -> Self {
         self.add_child(child);
@@ -180,6 +145,8 @@ impl Component for PwtFabMenu {
         };
 
         let mut container = Container::new()
+            .with_std_props(&props.std_props)
+            .listeners(&props.listeners)
             .class("pwt-fab-menu-container")
             .class(match props.align {
                 FabMenuAlign::Start => Some("pwt-fab-align-start"),
@@ -232,11 +199,3 @@ impl Component for PwtFabMenu {
         container.into()
     }
 }
-
-impl From<FabMenu> for VNode {
-    fn from(val: FabMenu) -> Self {
-        let key = val.key.clone();
-        let comp = VComp::new::<PwtFabMenu>(Rc::new(val), key);
-        VNode::from(comp)
-    }
-}
-- 
2.39.5



_______________________________________________
yew-devel mailing list
yew-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/yew-devel


  parent reply	other threads:[~2025-06-30  8:35 UTC|newest]

Thread overview: 21+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-06-30  8:24 [yew-devel] [PATCH yew-widget-toolkit/yew-widget-toolkit-assets v2 00/19] various touch improvements Dominik Csapak
2025-06-30  8:24 ` [yew-devel] [PATCH yew-widget-toolkit-assets v2 1/7] reset: remove the tap highlight color for chrome Dominik Csapak
2025-06-30  8:24 ` [yew-devel] [PATCH yew-widget-toolkit-assets v2 2/7] page: add more page animation styles Dominik Csapak
2025-06-30  8:24 ` [yew-devel] [PATCH yew-widget-toolkit-assets v2 3/7] page: animations: reverse the direction on X axis for RTL mode Dominik Csapak
2025-06-30  8:24 ` [yew-devel] [PATCH yew-widget-toolkit-assets v2 4/7] application bar: reduce horizontal padding Dominik Csapak
2025-06-30  8:24 ` [yew-devel] [PATCH yew-widget-toolkit-assets v2 5/7] application bar: reverse back arrow for rtl Dominik Csapak
2025-06-30  8:24 ` [yew-devel] [PATCH yew-widget-toolkit-assets v2 6/7] buttons: rework fab menu Dominik Csapak
2025-06-30  8:24 ` [yew-devel] [PATCH yew-widget-toolkit-assets v2 7/7] don't use 'html[dir="rtl"]' for RTL behavior Dominik Csapak
2025-06-30  8:24 ` [yew-devel] [PATCH yew-widget-toolkit v2 01/12] widget: implement Image widget Dominik Csapak
2025-06-30  8:24 ` [yew-devel] [PATCH yew-widget-toolkit v2 02/12] widget: button: don't hardcode icons font size Dominik Csapak
2025-06-30  8:25 ` [yew-devel] [PATCH yew-widget-toolkit v2 03/12] touch: page stack: add more animations Dominik Csapak
2025-06-30  8:25 ` [yew-devel] [PATCH yew-widget-toolkit v2 04/12] touch: application bar: set custom class on back button Dominik Csapak
2025-06-30  8:25 ` [yew-devel] [PATCH yew-widget-toolkit v2 05/12] touch: page stack: don't use animation by default Dominik Csapak
2025-06-30  8:25 ` [yew-devel] [PATCH yew-widget-toolkit v2 06/12] touch: material app: allow pass through of page animation style Dominik Csapak
2025-06-30  8:25 ` [yew-devel] [PATCH yew-widget-toolkit v2 07/12] touch: scaffold: fix overflow setting for body Dominik Csapak
2025-06-30  8:25 ` [yew-devel] [PATCH yew-widget-toolkit v2 08/12] touch: scaffold: use direction independent positioning for the FAB Dominik Csapak
2025-06-30  8:25 ` [yew-devel] [PATCH yew-widget-toolkit v2 09/12] touch: fab: add size option Dominik Csapak
2025-06-30  8:25 ` [yew-devel] [PATCH yew-widget-toolkit v2 10/12] touch: fab: convert to widget macro Dominik Csapak
2025-06-30  8:25 ` Dominik Csapak [this message]
2025-06-30  8:25 ` [yew-devel] [PATCH yew-widget-toolkit v2 12/12] touch: fab menu: rework fab menu Dominik Csapak
2025-06-30 10:56 ` [yew-devel] applied: [PATCH yew-widget-toolkit/yew-widget-toolkit-assets v2 00/19] various touch improvements Dietmar Maurer

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20250630082509.1202308-19-d.csapak@proxmox.com \
    --to=d.csapak@proxmox.com \
    --cc=yew-devel@lists.proxmox.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Service provided by Proxmox Server Solutions GmbH | Privacy | Legal