From: Dominik Csapak <d.csapak@proxmox.com>
To: yew-devel@lists.proxmox.com
Subject: [yew-devel] [PATCH yew-widget-toolkit 4/7] touch: slidable action: rename on_click to on_activate
Date: Tue, 24 Jun 2025 14:19:22 +0200 [thread overview]
Message-ID: <20250624121925.57056-9-d.csapak@proxmox.com> (raw)
In-Reply-To: <20250624121925.57056-1-d.csapak@proxmox.com>
to be consistent with buttons, etc.
Signed-off-by: Dominik Csapak <d.csapak@proxmox.com>
---
src/touch/slidable/slidable_action.rs | 18 +++++++++---------
1 file changed, 9 insertions(+), 9 deletions(-)
diff --git a/src/touch/slidable/slidable_action.rs b/src/touch/slidable/slidable_action.rs
index 263ae0e..de37445 100644
--- a/src/touch/slidable/slidable_action.rs
+++ b/src/touch/slidable/slidable_action.rs
@@ -11,7 +11,7 @@ use super::{SlidableActionMouseEvent, SlidableController};
/// A button which automatically connects to the [SlidableController].
///
-/// The [on_click](Self::on_click) handler gets an [SlidableActionMouseEvent] argument,
+/// The [on_activate](Self::on_activate) handler gets an [SlidableActionMouseEvent] argument,
/// which lets you collapse or dismiss the slidable.
#[derive(Properties, Clone, PartialEq)]
pub struct SlidableAction {
@@ -30,7 +30,7 @@ pub struct SlidableAction {
///
/// Emited when the user clicks on the entry.
#[prop_or_default]
- pub on_click: Option<Callback<SlidableActionMouseEvent>>,
+ pub on_activate: Option<Callback<SlidableActionMouseEvent>>,
}
impl SlidableAction {
@@ -51,9 +51,9 @@ impl SlidableAction {
self.icon_class = Some(icon_class.into());
}
- /// Builder style method to set the on_click callback.
- pub fn on_click(mut self, cb: impl IntoEventCallback<SlidableActionMouseEvent>) -> Self {
- self.on_click = cb.into_event_callback();
+ /// Builder style method to set the on_activate callback.
+ pub fn on_activate(mut self, cb: impl IntoEventCallback<SlidableActionMouseEvent>) -> Self {
+ self.on_activate = cb.into_event_callback();
self
}
}
@@ -102,11 +102,11 @@ impl Component for PwtSlidableAction {
let onclick = Callback::from({
let controller = self.controller.clone();
- let on_click = props.on_click.clone();
+ let on_activate = props.on_activate.clone();
move |event: MouseEvent| {
- if let Some(on_click) = &on_click {
+ if let Some(on_activate) = &on_activate {
let event = SlidableActionMouseEvent::new(event);
- on_click.emit(event.clone());
+ on_activate.emit(event.clone());
if let Some(controller) = &controller {
if event.get_dismiss() {
controller.dismiss();
@@ -115,7 +115,7 @@ impl Component for PwtSlidableAction {
}
}
} else {
- // Always collabse if action is without on_click callback
+ // Always collapse if action is without on_activate callback
if let Some(controller) = &controller {
controller.collapse();
}
--
2.39.5
_______________________________________________
yew-devel mailing list
yew-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/yew-devel
next prev parent reply other threads:[~2025-06-24 12:19 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-06-24 12:19 [yew-devel] [PATCH yew-widget-toolkit/yew-widget-toolkit-assets 00/11] various touch fixes Dominik Csapak
2025-06-24 12:19 ` [yew-devel] [PATCH yew-widget-toolkit-assets 1/4] slidable: don't add padding on top and bottom to actions Dominik Csapak
2025-06-24 12:19 ` [yew-devel] [PATCH yew-widget-toolkit-assets 2/4] slidable: set background-color to pwt-color-background for actions Dominik Csapak
2025-06-24 12:19 ` [yew-devel] [PATCH yew-widget-toolkit-assets 3/4] color scheme: add `pwt-default-colors` helper Dominik Csapak
2025-06-24 12:19 ` [yew-devel] [PATCH yew-widget-toolkit-assets 4/4] material: add rounded corners to bottom sheet Dominik Csapak
2025-06-24 12:19 ` [yew-devel] [PATCH yew-widget-toolkit 1/7] touch: gesture detector: introduce `InputEvent` Dominik Csapak
2025-06-24 16:27 ` [yew-devel] applied: " Dietmar Maurer
2025-06-24 12:19 ` [yew-devel] [PATCH yew-widget-toolkit 2/7] touch: gesture detector: implement a touch only mode Dominik Csapak
2025-06-24 12:19 ` [yew-devel] [PATCH yew-widget-toolkit 3/7] touch: fab: rename on_click to on_activate Dominik Csapak
2025-06-24 12:19 ` Dominik Csapak [this message]
2025-06-24 12:19 ` [yew-devel] [PATCH yew-widget-toolkit 5/7] touch: slidable action: add css classes property Dominik Csapak
2025-06-24 12:19 ` [yew-devel] [PATCH yew-widget-toolkit 6/7] touch: slidable: add on_tap callback Dominik Csapak
2025-06-24 12:19 ` [yew-devel] [PATCH yew-widget-toolkit 7/7] touch: slidable: cleanup unnecessary macro use Dominik Csapak
2025-06-25 6:57 ` [yew-devel] applied: [PATCH yew-widget-toolkit/yew-widget-toolkit-assets 00/11] various touch fixes Dietmar Maurer
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250624121925.57056-9-d.csapak@proxmox.com \
--to=d.csapak@proxmox.com \
--cc=yew-devel@lists.proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox