public inbox for yew-devel@lists.proxmox.com
 help / color / mirror / Atom feed
From: Thomas Lamprecht <t.lamprecht@proxmox.com>
To: yew-devel@lists.proxmox.com, Dominik Csapak <d.csapak@proxmox.com>
Subject: applied: [PATCH yew-widget-toolkit] state: (tree)store: fix mutable borrow during listener notification
Date: Thu, 15 Oct 2026 22:02:31 +0200	[thread overview]
Message-ID: <179209454892.3174600.14353212863019621678.b4-ty@b4> (raw)
In-Reply-To: <20260909091935.3557894-1-d.csapak@proxmox.com>

On Wed, 09 Sep 2026 11:18:12 +0200, Dominik Csapak wrote:
> In the (tree)store, when a write guard was dropped, the listener were
> notified while there was still a mutable borrow on it. This would lead
> to a panic when trying to access the tree or store inside the listener.
> 
> To avoid that, use a similar pattern as we have e.g. for SharedState or
> Selection, and use ManuallyDrop. Then we can drop the borrow before
> notifying the listeners.
> 
> [...]

Applied, thanks!

[1/1] state: (tree)store: fix mutable borrow during listener notification
      commit: 1d2153dd7ea90f09a658d628cd3af92a771e6197




      reply	other threads:[~2026-10-15 20:02 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-09-09  9:18 [PATCH yew-widget-toolkit] state: (tree)store: fix mutable borrow during listener notification Dominik Csapak
2026-10-15 20:02 ` Thomas Lamprecht [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=179209454892.3174600.14353212863019621678.b4-ty@b4 \
    --to=t.lamprecht@proxmox.com \
    --cc=d.csapak@proxmox.com \
    --cc=yew-devel@lists.proxmox.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Service provided by Proxmox Server Solutions GmbH | Privacy | Legal