From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from gate001.proxmox.com (gate001.proxmox.com [IPv6:2a0f:8001:1:32::40]) by lore.proxmox.com (Postfix) with ESMTPS id AFE3E1FF0BC for ; Thu, 15 Oct 2026 22:02:46 +0200 (CEST) Received: from gate001.proxmox.com (localhost.localdomain [127.0.0.1]) by gate001.proxmox.com (Proxmox) with ESMTP id 9ED7E2118F; Thu, 15 Oct 2026 22:02:45 +0200 (CEST) From: Thomas Lamprecht To: yew-devel@lists.proxmox.com, Dominik Csapak Subject: applied: [PATCH yew-widget-toolkit] state: (tree)store: fix mutable borrow during listener notification Date: Thu, 15 Oct 2026 22:02:31 +0200 Message-ID: <179209454892.3174600.14353212863019621678.b4-ty@b4> X-Mailer: git-send-email 2.47.3 In-Reply-To: <20260909091935.3557894-1-d.csapak@proxmox.com> References: <20260909091935.3557894-1-d.csapak@proxmox.com> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 8bit X-Bm-Milter-Handled: 55990f41-d878-4baa-be0a-ee34c49e34d2 X-Bm-Transport-Timestamp: 1792094561423 X-SPAM-LEVEL: Spam detection results: 0 AWL 0.540 Adjusted score from AWL reputation of From: address DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment (newer systems) RCVD_IN_DNSWL_MED -2.3 Sender listed at https://www.dnswl.org/, medium trust SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Message-ID-Hash: 4IL7AVMW4TZ7EMEVHEBF6EC6DPC42OT2 X-Message-ID-Hash: 4IL7AVMW4TZ7EMEVHEBF6EC6DPC42OT2 X-MailFrom: t.lamprecht@proxmox.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; loop; banned-address; emergency; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header X-Mailman-Version: 3.3.10 Precedence: list List-Id: Yew framework devel list at Proxmox List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: On Wed, 09 Sep 2026 11:18:12 +0200, Dominik Csapak wrote: > In the (tree)store, when a write guard was dropped, the listener were > notified while there was still a mutable borrow on it. This would lead > to a panic when trying to access the tree or store inside the listener. > > To avoid that, use a similar pattern as we have e.g. for SharedState or > Selection, and use ManuallyDrop. Then we can drop the borrow before > notifying the listeners. > > [...] Applied, thanks! [1/1] state: (tree)store: fix mutable borrow during listener notification commit: 1d2153dd7ea90f09a658d628cd3af92a771e6197