[PATCH] widget: grid picker: scroll the selected entry into view on open

[PATCH] widget: grid picker: scroll the selected entry into view on open

[Thomas Lamprecht]

When a picker opens, its table scrolls its own viewport to the
selected entry. That only works while the table is limited to the
picker's height. Since the combobox stopped giving its table the
pwt-fit class, nothing limits it: as a flex item it keeps its content
height, so it grows to the height of all rows and the picker's outer
container scrolls instead. The table then considers every row visible
and never scrolls. With 30 or more entries, where rows are rendered
on demand, the selected entry is not even rendered when the dropdown
tries to focus it, so a picker like the time zone selector always
opened at the top of the list.

Let the table shrink to the remaining picker height in the grid
picker itself, so this works for every picker and not only for the
combobox. As a side effect, virtual scrolling takes effect for long
lists instead of rendering every row, and the filter row stays in
place while the list scrolls. Pickers whose table still sets pwt-fit
behave as before.

Fixes: 5e37ff7fd87d ("Combobox: avoid use of pwt-fit (not needed)")
Signed-off-by: Thomas Lamprecht <t.lamprecht@proxmox.com>
---
 src/widget/grid_picker.rs | 3 +++
 1 file changed, 3 insertions(+)

diff --git a/src/widget/grid_picker.rs b/src/widget/grid_picker.rs
index caf6a187..b40ac922 100644
--- a/src/widget/grid_picker.rs
+++ b/src/widget/grid_picker.rs
@@ -188,6 +188,9 @@ impl<S: DataStore + 'static> Component for PwtGridPicker<S> {
             .cell_configuration(CellConfiguration::new().class("pwt-datatable-cell pwt-pointer"))
             .hover(true)
             .header_focusable(false)
+            // Let the table shrink to fit the picker, so it scrolls itself and can bring the
+            // selected entry into view, instead of the whole picker scrolling.
+            .min_height(0)
             .selection(self.selection.clone())
             .on_row_click({
                 let on_select = on_select.clone();
-- 
2.47.3

applied: [PATCH] widget: grid picker: scroll the selected entry into view on open

[Dominik Csapak]

On Tue, 06 Oct 2026 19:25:30 +0200, Thomas Lamprecht wrote:
> When a picker opens, its table scrolls its own viewport to the
> selected entry. That only works while the table is limited to the
> picker's height. Since the combobox stopped giving its table the
> pwt-fit class, nothing limits it: as a flex item it keeps its content
> height, so it grows to the height of all rows and the picker's outer
> container scrolls instead. The table then considers every row visible
> and never scrolls. With 30 or more entries, where rows are rendered
> on demand, the selected entry is not even rendered when the dropdown
> tries to focus it, so a picker like the time zone selector always
> opened at the top of the list.
> 
> [...]

Applied, thanks!

[1/1] widget: grid picker: scroll the selected entry into view on open
      commit: 4791dd9e38846e42866cabff955fce3f69175604