Re: [PATCH yew-comp 00/15] clippy clean up proxmox-yew-comp

[Dominik Csapak <d.csapak@proxmox.com>]

On 3/9/26 2:12 PM, Shannon Sterz wrote:
> On Mon Mar 9, 2026 at 1:54 PM CET, Dominik Csapak wrote:
>> most of them look fine to me IMO,
>> but I'm thinking maybe we should have (for the gui at least?) a custom
>> clippy config that removes some default lints, e.g. the
>> large_enum_variant and too_many_arguments lint
>> don' gain us much most of the time
>>
>> (Msg enums are only sent every once in a while,
>> so performance impact is negligible here;
>> long argument lists only get ignored most of the time anyway)
>>
>> also the commit:
>> fix various minor clippy lints has some in the list
>> that are not actually part of the commit?
>> (like again the 'too_many_arguments' one)
> 
> ah sorry something must have slipped into that list, i'll go over it
> again.
> 
>> so before i go and apply this (at least partially)
>> we might want to look over the lints again to see
>> which one we can/should ignore here?
> 
> that's fair i also don't think we gain much with the examples you
> mentioned. we could add a `lints` section to our cargo toml, something
> like this to start with possibly:
> 
> ```toml
> [lints.clippy]
> too_many_arguments = "allow"
> enum_variant_names = "allow"
> large_enum_variant = "allow"
> ```
> 
> what do you think?
> 
> -->8 snip 8<--


yeah i think allowing these for starters seems fine.
i didn't look through the list in detail, but
we could add them as we encounter them.

thanks!