From: Dietmar Maurer <dietmar@proxmox.com>
To: Yew framework devel list at Proxmox <yew-devel@lists.proxmox.com>,
Dominik Csapak <d.csapak@proxmox.com>
Subject: Re: [yew-devel] [PATCH yew-comp] fix #6382: tasks: don't add duplicate tasks into the list
Date: Mon, 12 May 2025 10:31:41 +0200 (CEST) [thread overview]
Message-ID: <1105368042.13622.1747038701538@webmail.proxmox.com> (raw)
In-Reply-To: <20250509071627.331064-1-d.csapak@proxmox.com>
>
> - let start = self.start;
> - filter["start"] = start.into();
> + let start = match (self.fresh_load, self.store.read().last()) {
> + (false, Some(last)) => last.starttime,
> + _ => 0,
> + };
> + if start > 0 && filter["until"].as_i64().unwrap_or(i64::MAX) > start {
> + filter["until"] = start.into();
> + }
The naming is quite confusing - maybe rename "start" into "until"?
Also, value "0" is not used (just a marker), so maybe it is cleaner to use an option?
_______________________________________________
yew-devel mailing list
yew-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/yew-devel
prev parent reply other threads:[~2025-05-12 8:31 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-05-09 7:16 Dominik Csapak
2025-05-12 8:31 ` Dietmar Maurer [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1105368042.13622.1747038701538@webmail.proxmox.com \
--to=dietmar@proxmox.com \
--cc=d.csapak@proxmox.com \
--cc=yew-devel@lists.proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Service provided by Proxmox Server Solutions GmbH | Privacy | Legal