public inbox for pve-user@lists.proxmox.com
 help / color / mirror / Atom feed
* [PVE-User] qemu-server: bug in vmconfig_apply_pending errors handling
@ 2021-07-04 17:29 alexandre derumier
  0 siblings, 0 replies; only message in thread
From: alexandre derumier @ 2021-07-04 17:29 UTC (permalink / raw)
  To: pve-user

Hi,

I'm still working on ipam support for qemu-server,

I have notice a bug in error handling of offline change apply, since
commit

https://git.proxmox.com/?p=qemu-server.git;a=commit;h=eb5e482ded9ae6aeb6575de9441b79b90a5de531

introduce $errors support



API2/Qemu.pm

-
               PVE::QemuServer::vmconfig_apply_pending($vmid, $conf, $
storecfg, $running);
+               PVE::QemuServer::vmconfig_apply_pending($vmid, $conf, $
storecfg, $running, $errors);

PVE/QemuServer.pm
 sub vmconfig_apply_pending {
-    my ($vmid, $conf, $storecfg) = @_;
+    my ($vmid, $conf, $storecfg, $errors) = @_;


The problem is the $running param used,  not existing in the sub.





^ permalink raw reply	[flat|nested] only message in thread

only message in thread, other threads:[~2021-07-04 17:29 UTC | newest]

Thread overview: (only message) (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-07-04 17:29 [PVE-User] qemu-server: bug in vmconfig_apply_pending errors handling alexandre derumier

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Service provided by Proxmox Server Solutions GmbH | Privacy | Legal