From: "DERUMIER, Alexandre" <Alexandre.DERUMIER@groupe-cyllene.com>
To: "pve-user@pve.proxmox.com" <pve-user@pve.proxmox.com>,
"f.ebner@proxmox.com" <f.ebner@proxmox.com>
Subject: Re: [PVE-User] [pve-devel] [PATCH qemu-server 08/10] memory: add virtio-mem support
Date: Tue, 20 Dec 2022 12:16:22 +0000 [thread overview]
Message-ID: <b354aab5e4791e7c862b15470ca24c273b8030be.camel@groupe-cyllene.com> (raw)
In-Reply-To: <15f5554d-3708-ac78-d2e2-1d797e55e211@proxmox.com>
Le mardi 20 décembre 2022 à 11:26 +0100, Fiona Ebner a écrit :
> Isn't ($MAX_MEM - $static_memory) / 32000 always strictly greater
> than
> 1? And if it could get smaller than 1, we also might have issues with
> the int()+1 approach, because the result of the first log() will
> become
> negative.
>
> To be on the safe side we could just move the minimum check up:
>
> my $blocksize = ($MAX_MEM - $static_memory) / 32000;
> $blocksize = 2 if $blocksize < 2;
> $blocksize = 2**(ceil(log($blocksize)/log(2)));
I think your are right.
I totally forget than mem was in bytes,
so the minimum blocksize is 2048
with a MAX_MEM of 64gb, the minimum blocksize is 2048.
(I remember now that I wanted 64GB minimum to have transparent huge
working out of the box).
if MAX_MEM was allowed 32gb ,the minimum blocksize with ceil is 1024.
so we need to force it to 2048
I'll rework the patch, thanks !
parent reply other threads:[~2022-12-20 12:23 UTC|newest]
Thread overview: expand[flat|nested] mbox.gz Atom feed
[parent not found: <15f5554d-3708-ac78-d2e2-1d797e55e211@proxmox.com>]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=b354aab5e4791e7c862b15470ca24c273b8030be.camel@groupe-cyllene.com \
--to=alexandre.derumier@groupe-cyllene.com \
--cc=f.ebner@proxmox.com \
--cc=pve-user@pve.proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox