public inbox for pve-user@lists.proxmox.com
 help / color / mirror / Atom feed
* Re: [PVE-User] PBS and ZFS Pools Compression?
       [not found] <mailman.181.1617896884.359.pve-user@lists.proxmox.com>
@ 2021-04-08 16:22 ` Geoff Seeley
  0 siblings, 0 replies; 9+ messages in thread
From: Geoff Seeley @ 2021-04-08 16:22 UTC (permalink / raw)
  To: pve-user

>
> > I may be wrong, but AFAIK ZFS detects compressed data and thus it is not
> > doing double-compression in such cases,
>
> AFAIK the only way to detect compressed data is to actually compress it,
> then
> test the size. So this is double-compression ...
>

ZFS compression is a little more complex than this, but the good news is
that ZFS is also smart enough not to do this!

This is a good article on the subject:
https://klarasystems.com/articles/openzfs1-understanding-transparent-compression/

TL;DR: Enable compression at the pool level and forget about it.

-Geoff


^ permalink raw reply	[flat|nested] 9+ messages in thread

* Re: [PVE-User] PBS and ZFS Pools Compression?
  2021-04-08 18:06 Dietmar Maurer
  2021-04-08 23:51 ` Roland
@ 2021-04-09  6:54 ` Fabian Grünbichler
  1 sibling, 0 replies; 9+ messages in thread
From: Fabian Grünbichler @ 2021-04-09  6:54 UTC (permalink / raw)
  To: Geoff Seeley, Proxmox VE user list

On April 8, 2021 8:06 pm, Dietmar Maurer wrote:
>> This is a good article on the subject:
>> https://klarasystems.com/articles/openzfs1-understanding-transparent-compression/
> 
> Can't find where the explain it. ZFS magically detects if data is compressible?
> Please can someone give me a hint how they do that?

no. they compress, and if the result is over a certain threshold, they 
save the uncompressed data to avoid the decompress overhead for barely 
any/no gain.




^ permalink raw reply	[flat|nested] 9+ messages in thread

* Re: [PVE-User] PBS and ZFS Pools Compression?
  2021-04-08 18:06 Dietmar Maurer
@ 2021-04-08 23:51 ` Roland
  2021-04-09  6:54 ` Fabian Grünbichler
  1 sibling, 0 replies; 9+ messages in thread
From: Roland @ 2021-04-08 23:51 UTC (permalink / raw)
  To: Proxmox VE user list, Dietmar Maurer, Geoff Seeley

i know that there was smartcompression feature in nexenta:

https://openzfs.org/w/images/4/4d/Compression-Saso_Kiselkov.pdf

afaik, it does not exist in zfsonlinux/openzfs.

on my system, i'm getting

- <250MB/s when writing uncompressible data to zfs pool with lz4 enabled

and

- >450MB/s when writing uncompressible data to zfs pool without compression

regards
roland

Am 08.04.21 um 20:06 schrieb Dietmar Maurer:
>> This is a good article on the subject:
>> https://klarasystems.com/articles/openzfs1-understanding-transparent-compression/
> Can't find where the explain it. ZFS magically detects if data is compressible?
> Please can someone give me a hint how they do that?
>
>
> _______________________________________________
> pve-user mailing list
> pve-user@lists.proxmox.com
> https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-user
>



^ permalink raw reply	[flat|nested] 9+ messages in thread

* Re: [PVE-User] PBS and ZFS Pools Compression?
@ 2021-04-08 18:06 Dietmar Maurer
  2021-04-08 23:51 ` Roland
  2021-04-09  6:54 ` Fabian Grünbichler
  0 siblings, 2 replies; 9+ messages in thread
From: Dietmar Maurer @ 2021-04-08 18:06 UTC (permalink / raw)
  To: Proxmox VE user list, Geoff Seeley

> This is a good article on the subject:
> https://klarasystems.com/articles/openzfs1-understanding-transparent-compression/

Can't find where the explain it. ZFS magically detects if data is compressible?
Please can someone give me a hint how they do that?




^ permalink raw reply	[flat|nested] 9+ messages in thread

* Re: [PVE-User] PBS and ZFS Pools Compression?
@ 2021-04-08 15:47 Dietmar Maurer
  0 siblings, 0 replies; 9+ messages in thread
From: Dietmar Maurer @ 2021-04-08 15:47 UTC (permalink / raw)
  To: Proxmox VE user list, Mikhail, Lindsay Mathieson, Roland


> I may be wrong, but AFAIK ZFS detects compressed data and thus it is not
> doing double-compression in such cases,

AFAIK the only way to detect compressed data is to actually compress it, then
test the size. So this is double-compression ...




^ permalink raw reply	[flat|nested] 9+ messages in thread

* Re: [PVE-User] PBS and ZFS Pools Compression?
  2021-04-08 13:13   ` Lindsay Mathieson
@ 2021-04-08 15:19     ` Mikhail
  0 siblings, 0 replies; 9+ messages in thread
From: Mikhail @ 2021-04-08 15:19 UTC (permalink / raw)
  To: Proxmox VE user list, Lindsay Mathieson, Roland

On 4/8/21 4:13 PM, Lindsay Mathieson wrote:
> On 8/04/2021 11:12 pm, Roland wrote:
>> i think it's counter productive, as you are wasting cpu for
>> compress/uncompress data, 
> 
> Yah, I thought so, thanks.
> 

I may be wrong, but AFAIK ZFS detects compressed data and thus it is not
doing double-compression in such cases, so I guess there's no harm here
(we also have lz4 enabled on datastore where Proxmox sends backups).
Also lz4 is cheap, so I doubt it has any significant impact on modern CPUs.

regards,



^ permalink raw reply	[flat|nested] 9+ messages in thread

* Re: [PVE-User] PBS and ZFS Pools Compression?
  2021-04-08 13:12 ` Roland
@ 2021-04-08 13:13   ` Lindsay Mathieson
  2021-04-08 15:19     ` Mikhail
  0 siblings, 1 reply; 9+ messages in thread
From: Lindsay Mathieson @ 2021-04-08 13:13 UTC (permalink / raw)
  To: Roland, Proxmox VE user list

On 8/04/2021 11:12 pm, Roland wrote:
> i think it's counter productive, as you are wasting cpu for
> compress/uncompress data, 

Yah, I thought so, thanks.

-- 
Lindsay




^ permalink raw reply	[flat|nested] 9+ messages in thread

* Re: [PVE-User] PBS and ZFS Pools Compression?
  2021-04-08 13:06 Lindsay Mathieson
@ 2021-04-08 13:12 ` Roland
  2021-04-08 13:13   ` Lindsay Mathieson
  0 siblings, 1 reply; 9+ messages in thread
From: Roland @ 2021-04-08 13:12 UTC (permalink / raw)
  To: Proxmox VE user list, Lindsay Mathieson

hi,

i think it's counter productive, as you are wasting cpu for
compress/uncompress data,
which should not be further compressible (except some smaller files like
img.fidx etc)

regards
roland

Am 08.04.21 um 15:06 schrieb Lindsay Mathieson:
> Setup a ZFS RAID1 pool on my PBS server and enabled lz4 compression on
> it (habit). But given the backups are already compressed, its not
> really going to gain anything is it? possibly even counter productive?
>
>
> Thanks.
>



^ permalink raw reply	[flat|nested] 9+ messages in thread

* [PVE-User] PBS and ZFS Pools Compression?
@ 2021-04-08 13:06 Lindsay Mathieson
  2021-04-08 13:12 ` Roland
  0 siblings, 1 reply; 9+ messages in thread
From: Lindsay Mathieson @ 2021-04-08 13:06 UTC (permalink / raw)
  To: pve-user

Setup a ZFS RAID1 pool on my PBS server and enabled lz4 compression on 
it (habit). But given the backups are already compressed, its not really 
going to gain anything is it? possibly even counter productive?


Thanks.

-- 
Lindsay




^ permalink raw reply	[flat|nested] 9+ messages in thread

end of thread, other threads:[~2021-04-09  6:54 UTC | newest]

Thread overview: 9+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
     [not found] <mailman.181.1617896884.359.pve-user@lists.proxmox.com>
2021-04-08 16:22 ` [PVE-User] PBS and ZFS Pools Compression? Geoff Seeley
2021-04-08 18:06 Dietmar Maurer
2021-04-08 23:51 ` Roland
2021-04-09  6:54 ` Fabian Grünbichler
  -- strict thread matches above, loose matches on Subject: below --
2021-04-08 15:47 Dietmar Maurer
2021-04-08 13:06 Lindsay Mathieson
2021-04-08 13:12 ` Roland
2021-04-08 13:13   ` Lindsay Mathieson
2021-04-08 15:19     ` Mikhail

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Service provided by Proxmox Server Solutions GmbH | Privacy | Legal