public inbox for pve-user@lists.proxmox.com
 help / color / mirror / Atom feed
From: Jan Vlach <janus@volny.cz>
To: Proxmox VE user list <pve-user@lists.proxmox.com>
Subject: Re: [PVE-User] Proxmox VE 8.1 released!
Date: Fri, 24 Nov 2023 15:24:24 +0100	[thread overview]
Message-ID: <03B4A4F0-747A-4E11-A487-237E85624710@volny.cz> (raw)
In-Reply-To: <mailman.296.1700814059.422.pve-user@lists.proxmox.com>


as per https://github.com/openzfs/zfs/issues/15526 <https://github.com/openzfs/zfs/issues/15526> discussion,

this is the workaround for the silent data corruption:\x10

echo 0 >  /sys/module/zfs/parameters/zfs_dmu_offset_next_sync

TL;DR version: this parameter (https://openzfs.github.io/openzfs-docs/Performance%20and%20Tuning/Module%20Parameters.html#zfs-dmu-offset-next-sync <https://openzfs.github.io/openzfs-docs/Performance%20and%20Tuning/Module%20Parameters.html#zfs-dmu-offset-next-sync>) has been switched to 1 in 2.1.5 to trade safety for performance. 


reproducer script is here:
https://github.com/openzfs/zfs/issues/15526#issuecomment-1824966856 <https://github.com/openzfs/zfs/issues/15526#issuecomment-1824966856>

I've managed to hit the data corruption with 8 simultaneous instances of the script. Allegedly, one needs a beefy computer to hit the bug, but I've managed to hit it on 2 core AMD fujitsu futro thin client running opnsense too. (after couple tries)

I didn't hit the behavior on debian 11 (PVE8), but managed to reproduce it in debian 12 (PVE8), FreeBSD 13 and 14.
Illumos' ZFS is fine.

It seems that the bug gets more exposed, because both freebsd's and coreutils's >8.32 cp uses 'file_copy_range'.

JV

  parent reply	other threads:[~2023-11-24 14:25 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-11-23 14:27 Martin Maurer
2023-11-23 22:35 ` Jan Vlach
2023-11-23 22:43   ` Jan Vlach
     [not found]     ` <mailman.293.1700812718.422.pve-user@lists.proxmox.com>
2023-11-24  8:12       ` Fabian Grünbichler
     [not found]         ` <mailman.296.1700814059.422.pve-user@lists.proxmox.com>
2023-11-24  8:32           ` Fabian Grünbichler
2023-11-24 14:24           ` Jan Vlach [this message]
2023-11-24  7:27   ` Fabian Grünbichler

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=03B4A4F0-747A-4E11-A487-237E85624710@volny.cz \
    --to=janus@volny.cz \
    --cc=pve-user@lists.proxmox.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Service provided by Proxmox Server Solutions GmbH | Privacy | Legal