From: Christoph Heiss <c.heiss@proxmox.com>
To: Lukas Wagner <l.wagner@proxmox.com>
Cc: Proxmox VE development discussion <pve-devel@lists.proxmox.com>
Subject: Re: [pve-devel] [PATCH manager 2/2] ui: ldap: add 'Check connection' checkbox as advanced option
Date: Tue, 1 Aug 2023 11:18:51 +0200 [thread overview]
Message-ID: <zrv6m2k6xjurcfwbg7znko7ky7b253acrynucgo55cpuu72fyu@jviketywlmw7> (raw)
In-Reply-To: <CUDO35NLCIJ3.3FAGR2E8RPDU6@pali>
On Fri, Jul 28, 2023 at 10:37:12AM +0200, Lukas Wagner wrote:
>
> On Thu Jul 27, 2023 at 3:33 PM CEST, Christoph Heiss wrote:
> > The checkbox is enabled by default for new realms, setting the new
> > `check-connection` parameter.
> >
> > Won't effect existing configurations, i.e. being opt-in for them, to not
> > break existing setups.
> As mentioned in my other reply, I think setting the new parameter by default
> should not be a problem, as long as it is only in the GUI.
> >
> > --- a/www/manager6/dc/AuthEditLDAP.js
> > +++ b/www/manager6/dc/AuthEditLDAP.js
> > @@ -79,6 +79,21 @@ Ext.define('PVE.panel.LDAPInputPanel', {
> > },
> > ];
> >
> > + me.advancedItems = [
> > + {
> > + xtype: 'proxmoxcheckbox',
> > + fieldLabel: gettext('Check connection'),
> > + name: 'check-connection',
> > + uncheckedValue: 0,
> > + checked: me.isCreate,
> > + autoEl: {
> > + tag: 'div',
> > + 'data-qtip':
> > + gettext('Verify connection parameters and bind credentials on save'),
> > + },
> > + },
> > + ];
> > +
> > me.callParent();
> > },
> > onGetValues: function(values) {
>
> AD realms have their own GUI component, so I guess it would also make sense to
> add the new parameter there.
Right, forgot that. I'll add it for v2, thanks!
prev parent reply other threads:[~2023-08-01 9:19 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-07-27 13:33 [pve-devel] [PATCH access-control/manager 0/2] ldap: check bind connection on realm add/update Christoph Heiss
2023-07-27 13:33 ` [pve-devel] [PATCH access-control 1/2] api: domains: add off-by-default `check-connection` parameter Christoph Heiss
2023-07-28 8:29 ` Lukas Wagner
2023-08-01 9:17 ` Christoph Heiss
2023-07-27 13:33 ` [pve-devel] [PATCH manager 2/2] ui: ldap: add 'Check connection' checkbox as advanced option Christoph Heiss
2023-07-28 8:37 ` Lukas Wagner
2023-08-01 9:18 ` Christoph Heiss [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=zrv6m2k6xjurcfwbg7znko7ky7b253acrynucgo55cpuu72fyu@jviketywlmw7 \
--to=c.heiss@proxmox.com \
--cc=l.wagner@proxmox.com \
--cc=pve-devel@lists.proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox