public inbox for pve-devel@lists.proxmox.com
 help / color / mirror / Atom feed
From: Gabriel Goller <g.goller@proxmox.com>
To: Daniel Herzig <d.herzig@proxmox.com>
Cc: pve-devel@lists.proxmox.com
Subject: Re: [PATCH container] fix #7568: ensure new vmid in pve ipams when cloning containers
Date: Fri, 8 May 2026 13:30:46 +0200	[thread overview]
Message-ID: <zq3htlve55hj32glwolfrz4umtab5pefahoxsxjezudain4vyq@vg7l5fw7r7jv> (raw)
In-Reply-To: <20260507112341.268585-1-d.herzig@proxmox.com>

On 07.05.2026 13:23, Daniel Herzig wrote:
> This patch addresses the incorrect application of the original
> vmid to cloned containers in pve ipams, which results in duplicate
> vmid entries in the `/cluster/sdn/ipams/pve/status` endpoint.
> 
> Signed-off-by: Daniel Herzig <d.herzig@proxmox.com>

LGTM, Consider:

Reviewed-by: Gabriel Goller <g.goller@proxmox.com>

> ---
> THX @Gabriel for the offline input.
> 
>  src/PVE/API2/LXC.pm | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/src/PVE/API2/LXC.pm b/src/PVE/API2/LXC.pm
> index 838dd76..89d8a53 100644
> --- a/src/PVE/API2/LXC.pm
> +++ b/src/PVE/API2/LXC.pm
> @@ -2235,7 +2235,7 @@ __PACKAGE__->register_method({
>                          my $rootdir = PVE::LXC::mount_all($newid, $storecfg, $conf, 1);
>  
>                          eval {
> -                            PVE::LXC::create_ifaces_ipams_ips($conf, $vmid);
> +                            PVE::LXC::create_ifaces_ipams_ips($conf, $newid);
>                              my $lxc_setup = PVE::LXC::Setup->new($conf, $rootdir);
>                              $lxc_setup->post_clone_hook($conf);
>                          };
> -- 
> 2.47.3




      reply	other threads:[~2026-05-08 11:31 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-05-07 11:23 [PATCH container] fix #7568: ensure new vmid in pve ipams when cloning containers Daniel Herzig
2026-05-08 11:30 ` Gabriel Goller [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=zq3htlve55hj32glwolfrz4umtab5pefahoxsxjezudain4vyq@vg7l5fw7r7jv \
    --to=g.goller@proxmox.com \
    --cc=d.herzig@proxmox.com \
    --cc=pve-devel@lists.proxmox.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Service provided by Proxmox Server Solutions GmbH | Privacy | Legal