public inbox for pve-devel@lists.proxmox.com
 help / color / mirror / Atom feed
From: Arthur Bied-Charreton <a.bied-charreton@proxmox.com>
To: pve-devel@lists.proxmox.com
Subject: Re: [PATCH pve-manager] fix #7337: Keep track of deep link on OpenID login
Date: Thu, 12 Mar 2026 11:49:36 +0100	[thread overview]
Message-ID: <zmuybnjepyjj4ic2aqubpxytnynsy2nwl4j3v7cmto6cb5e64r@c23c7bbom6xj> (raw)
In-Reply-To: <20260312101227.212668-1-a.bied-charreton@proxmox.com>

On Thu, Mar 12, 2026 at 11:12:27AM +0100, Arthur Bied-Charreton wrote:
> Previously, when opening a deep link without being logged into PVE, the
> hash was getting lost, redirecting the user to / instead of
> /#<deeplink>.
> 
> Store `window.location.hash` in sessionStorage (per-tab storage) before
> redirecting to the login URL, and add it to `Ext.History` after successful
> login to direct the user to the deeplink they opened.
> 
> Signed-off-by: Arthur Bied-Charreton <a.bied-charreton@proxmox.com>
> 
[...]

Quick side note that this is also an issue in PBS, will send a follow-up
patch to the pbs list once we validate this approach/agree on another one
here. 




  reply	other threads:[~2026-03-12 10:50 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-03-12 10:12 Arthur Bied-Charreton
2026-03-12 10:49 ` Arthur Bied-Charreton [this message]
2026-03-12 13:43 ` applied: " Dominik Csapak

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=zmuybnjepyjj4ic2aqubpxytnynsy2nwl4j3v7cmto6cb5e64r@c23c7bbom6xj \
    --to=a.bied-charreton@proxmox.com \
    --cc=pve-devel@lists.proxmox.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Service provided by Proxmox Server Solutions GmbH | Privacy | Legal