Re: [pve-devel] [PATCH proxmox-firewall 2/2] firewall: add subcommands to proxmox-firewall binary

From: Gabriel Goller <g.goller@proxmox.com>
To: Stefan Hanreich <s.hanreich@proxmox.com>
Cc: pve-devel@lists.proxmox.com
Subject: Re: [pve-devel] [PATCH proxmox-firewall 2/2] firewall: add subcommands to proxmox-firewall binary
Date: Wed, 23 Apr 2025 13:46:16 +0200	[thread overview]
Message-ID: <z6xoalxyyekii6uiq2jczyaw6lp7e34nza557qowsju2lh7i7q@v7neadpkerd7> (raw)
In-Reply-To: <20250414154455.274151-3-s.hanreich@proxmox.com>

On 14.04.2025 17:44, Stefan Hanreich wrote:
> [snip]
>+fn main() -> Result<(), Error> {
>+    let mut args = Arguments::from_env();
>+
>+    let parsed_command = args.subcommand()?
>+        .ok_or_else(|| format_err!("no subcommand specified"))?

Maybe we could print HELP here again? So that you don't have to guess
the subcommands.

>+        .parse();
>+
>+    if let Ok(command) = parsed_command {
>+        run_command(command)
>+    } else {
>+        eprintln!("Invalid command specified!\n{}", HELP);
>+        std::process::exit(1);
>+    }
>+
>+}

Also this file needs a `cargo fmt` :)

Otherwise the whole series looks good, consider:
Reviewed-by: Gabriel Goller <g.goller@proxmox.com>
Tested-by: Gabriel Goller <g.goller@proxmox.com>

_______________________________________________
pve-devel mailing list
pve-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel