[pve-devel] [PATCH common] file: add missing use statement

[pve-devel] [PATCH common] file: add missing use statement

[Friedrich Weber]

This fixes an "create storage failed: Undefined subroutine
&PVE::File::encode called" error when creating a PBS storage.

Fixes: 4b53440 ("create dedicated PVE::File module")
Signed-off-by: Friedrich Weber <f.weber@proxmox.com>
---
 src/PVE/File.pm | 1 +
 1 file changed, 1 insertion(+)

diff --git a/src/PVE/File.pm b/src/PVE/File.pm
index 53af963..444e7ff 100644
--- a/src/PVE/File.pm
+++ b/src/PVE/File.pm
@@ -2,6 +2,7 @@ package PVE::File;
 
 use v5.36;
 
+use Encode qw(encode);
 use Fcntl qw(SEEK_SET SEEK_END);
 use File::Basename qw(dirname);
 use File::Path qw(make_path);
-- 
2.47.3



_______________________________________________
pve-devel mailing list
pve-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel

Re: [pve-devel] [PATCH common] file: add missing use statement

[Gabriel Goller]

This also broke creating and updating fabrics. This patchs fixes it
though, thanks!

Consider:

Reviewed-by: Gabriel Goller <g.goller@proxmox.com>


_______________________________________________
pve-devel mailing list
pve-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel

[pve-devel] applied: [PATCH common] file: add missing use statement

[Thomas Lamprecht]

On Wed, 05 Nov 2025 12:40:47 +0100, Friedrich Weber wrote:
> This fixes an "create storage failed: Undefined subroutine
> &PVE::File::encode called" error when creating a PBS storage.
> 
> 

Applied, thanks! I also fixed another issue I spotted in the module and added a
basic test harness to avoid regressing here again in the future.

[1/1] file: add missing use statement
      commit: c9a6ad626f06754a9a8f877075b7f178631d39be


_______________________________________________
pve-devel mailing list
pve-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel