public inbox for pve-devel@lists.proxmox.com
 help / color / mirror / Atom feed
From: Christoph Heiss <c.heiss@proxmox.com>
To: Thomas Lamprecht <t.lamprecht@proxmox.com>
Cc: Gilberto Ferreira <gilberto.nunes32@gmail.com>,
	 Proxmox VE development discussion <pve-devel@lists.proxmox.com>
Subject: Re: [pve-devel] [PATCH installer v2 1/6] fix #4829: install: add new ZFS `arc_max` setup option
Date: Fri, 27 Oct 2023 10:29:26 +0200	[thread overview]
Message-ID: <yfgwihon7r4kzrtrbnyn34trcknd4kctxdnll2shahdcw3c6ca@ns722pncaxew> (raw)
In-Reply-To: <97055168-3ed7-4338-8890-05bbe8c893ee@proxmox.com>



On Wed, Oct 25, 2023 at 07:09:00PM +0200, Thomas Lamprecht wrote:
>
> Am 25/10/2023 um 10:28 schrieb Christoph Heiss:
> > On Tue, Oct 24, 2023 at 08:59:36AM -0300, Gilberto Ferreira via pve-devel wrote:
> >
> > Currently, this isn't planned, although - since that setting is exposed
> > after all in the installer in the future - it would be kind of sensible
> > to add it to the GUI as well, I guess.
> > But as a separate series from this one, of course.
> >
> > CC @Thomas - what do you think?
>
> We would need to either have a separate config entry, that can easily
> get out of sync with the actual configured values, or parse all possible
> ways to set this, e.g., modprobe configs, which isn't too nice.
Yeah, that actually seems like a big problem.

>
> With a few trade-offs/limitations one could probably work around that,
> but IMO it can be a bit too much hassle for something that one normally
> changes only once or twice (or once this change is in, probably never
> for new setups), so for now I'd keep this manual.
Then I'd also leave it at this, just being able to change it in the
installer and afterwards only "manually".

It is more than sufficiently documented in our guides how to change
that, let alone searching for that topic on the internet.

Thanks for chiming in!




  reply	other threads:[~2023-10-27  8:29 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-10-24 11:55 [pve-devel] [PATCH installer v2 0/6] fix #4829: set up lower default limit for ZFS ARC in installer Christoph Heiss
2023-10-24 11:55 ` [pve-devel] [PATCH installer v2 1/6] fix #4829: install: add new ZFS `arc_max` setup option Christoph Heiss
2023-10-24 15:05   ` Thomas Lamprecht
2023-10-25  8:17     ` Christoph Heiss
     [not found]   ` <mailman.181.1698148853.385.pve-devel@lists.proxmox.com>
2023-10-25  8:28     ` Christoph Heiss
2023-10-25 17:09       ` Thomas Lamprecht
2023-10-27  8:29         ` Christoph Heiss [this message]
2023-10-24 11:55 ` [pve-devel] [PATCH installer v2 2/6] fix #4829: proxinstall: expose new `arc_max` ZFS option for PVE installations Christoph Heiss
2023-10-24 11:55 ` [pve-devel] [PATCH installer v2 3/6] fix #4829: test: add tests for new zfs_arc_max calculations Christoph Heiss
2023-10-24 11:55 ` [pve-devel] [PATCH installer v2 4/6] tui: views: add optional suffix label for `NumericEditView`s Christoph Heiss
2023-10-24 11:55 ` [pve-devel] [PATCH installer v2 5/6] fix #4829: tui: setup: add new ZFS `arc_max` option Christoph Heiss
2023-10-24 11:55 ` [pve-devel] [PATCH installer v2 6/6] fix #4829: tui: bootdisk: expose new `arc_max` ZFS option for PVE installations Christoph Heiss
2023-10-24 15:07 ` [pve-devel] [PATCH installer v2 0/6] fix #4829: set up lower default limit for ZFS ARC in installer Thomas Lamprecht

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=yfgwihon7r4kzrtrbnyn34trcknd4kctxdnll2shahdcw3c6ca@ns722pncaxew \
    --to=c.heiss@proxmox.com \
    --cc=gilberto.nunes32@gmail.com \
    --cc=pve-devel@lists.proxmox.com \
    --cc=t.lamprecht@proxmox.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Service provided by Proxmox Server Solutions GmbH | Privacy | Legal