From: Gabriel Goller <g.goller@proxmox.com>
To: Thomas Lamprecht <t.lamprecht@proxmox.com>
Cc: Proxmox VE development discussion <pve-devel@lists.proxmox.com>
Subject: Re: [pve-devel] [PATCH manager] www: sdn: improve naming of vm network device in bridge view
Date: Mon, 17 Nov 2025 15:30:06 +0100 [thread overview]
Message-ID: <xqij23rplticyzjj6ju4eshakcscsivyfvxxvre3jy56u2gm6n@gjnu4k34cv6n> (raw)
In-Reply-To: <8c8a9385-9152-4447-9810-cb91a38a5db0@proxmox.com>
On 17.11.2025 15:25, Thomas Lamprecht wrote:
> Am 17.11.25 um 15:03 schrieb Gabriel Goller:
> > When selecting a bridge we show all the ports and also decode the
> > firewall bridge port name. The name contaians the vmid and the vm
> > network device index. If we apply
> > https://lore.proxmox.com/pve-devel/20251117140121.160192-1-g.goller@proxmox.com/
> > the full interface name will be shown (`net{index}`), so this is a
> > better name for the column.
> >
> > Signed-off-by: Gabriel Goller <g.goller@proxmox.com>
> > ---
> > www/manager6/sdn/ZoneBridgesPanel.js | 2 +-
> > 1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/www/manager6/sdn/ZoneBridgesPanel.js b/www/manager6/sdn/ZoneBridgesPanel.js
> > index 600b23b0a8f8..f89f7956434a 100644
> > --- a/www/manager6/sdn/ZoneBridgesPanel.js
> > +++ b/www/manager6/sdn/ZoneBridgesPanel.js
> > @@ -76,7 +76,7 @@ Ext.define('PVE.sdn.ZoneBridgePortsPanel', {
> > dataIndex: 'vmid',
> > },
> > {
> > - text: gettext('Network Device Index'),
> > + text: gettext('VM Network Device'),
>
> Is this really limited to VMs or can CTs also be shown? For the latter we
> might want to use "Guest Network Device"
CTs can also be shown. Agree, I'll send a new patch!
We also show "VMID" in the other column is that fine for for CTs?
> > flex: 1,
> > sortable: true,
> > dataIndex: 'index',
>
_______________________________________________
pve-devel mailing list
pve-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel
next prev parent reply other threads:[~2025-11-17 14:30 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-11-17 14:03 Gabriel Goller
2025-11-17 14:25 ` Thomas Lamprecht
2025-11-17 14:30 ` Gabriel Goller [this message]
2025-11-17 14:42 ` Thomas Lamprecht
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=xqij23rplticyzjj6ju4eshakcscsivyfvxxvre3jy56u2gm6n@gjnu4k34cv6n \
--to=g.goller@proxmox.com \
--cc=pve-devel@lists.proxmox.com \
--cc=t.lamprecht@proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox